Welcome! Log In Create A New Profile

Advanced

Re: cache: move open to thread pool

Roman Arutyunyan
September 09, 2021 06:50AM
Hi Noam,

On Thu, Sep 02, 2021 at 07:16:55PM +0300, Noam Cvikel wrote:
> Hello,
>
> Didn't see a way to get into the thread after joining the list, but
> hopefully this still replies correctly.
>
> First of all thank you for the prompt response and updated patch.
> We implemented the updated async open patch, and started testing it in our
> lab.

Good news, thanks.

> The static module part of the patch isn't updated yet, so we didn't apply
> it.
> While we're almost not using the static module, we'd still gladly test it
> and share a feedback, once the patch is updated.

The latest patchset from me includes the static module part too, and it should
work with the latest nginx source. We'd appreciate feedback from you on the
static part too, if that's something you can do.

> The patch itself is looking good. We've not encountered any errors or
> issues, and we see a significant performance improvement.
> We're working with spinning disks (HDD), and before applying the patch we
> would sometimes see the main thread get stuck on open IO anywhere between
> 2-15 seconds.
> After applying the patch, we see that an iteration of the worker's main
> loop doesn't take more than 10ms! Significantly reducing the penalty for
> other transactions.

Great. Can you measure the overall performance improvement?

> We will keep monitoring the changes and report. We would really like to see
> this patch integrated into the official branch. If we can do anything else
> to help make this happen - please let us know.

Thanks for you feedback. When you have more data or bugs to report, we'd
appreciate that too.

> Best,
>
>
>
> *Noam Cvikel*
> Qwilt | | noamc@qwilt.com

> _______________________________________________
> nginx-devel mailing list
> nginx-devel@nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel


--
Roman Arutyunyan
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 1980 August 07, 2018 05:28PM

Re: cache: move open to thread pool

Maxim Dounin 492 August 08, 2018 02:18PM

RE: cache: move open to thread pool

erankor 412 August 08, 2018 03:46PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 309 August 27, 2018 06:00PM

RE: cache: move open to thread pool

erankor 366 August 28, 2018 05:18AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 337 August 09, 2018 05:44PM

Re: cache: move open to thread pool

Maxim Dounin 752 August 10, 2018 07:42AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 314 August 27, 2018 05:40PM

Re: cache: move open to thread pool

Maxim Dounin 417 September 03, 2018 12:10PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 349 September 04, 2018 08:00PM

Re: cache: move open to thread pool

Maxim Dounin 323 September 13, 2018 02:12PM

Re: cache: move open to thread pool

Roman Arutyunyan 409 October 04, 2018 05:34AM

Re: cache: move open to thread pool

Roman Arutyunyan 433 November 01, 2018 08:30AM

Re: cache: move open to thread pool

Maxim Konovalov 301 November 01, 2018 12:08PM

Re: cache: move open to thread pool

Roman Arutyunyan 59 August 03, 2021 04:52AM

Re: cache: move open to thread pool

Maxim Konovalov 311 November 08, 2018 09:20AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 336 November 15, 2018 05:54PM

Re: cache: move open to thread pool

Maxim Konovalov 369 November 16, 2018 04:12AM

Re: cache: move open to thread pool

Maxim Konovalov 333 December 05, 2018 04:44AM

Re: cache: move open to thread pool

Maxim Konovalov 291 January 10, 2019 03:32AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 317 January 14, 2019 08:54PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 279 January 22, 2019 01:22PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 305 January 22, 2019 02:36PM

Re: cache: move open to thread pool

Maxim Konovalov 293 January 23, 2019 07:40AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 276 February 06, 2019 04:20PM

Re: cache: move open to thread pool

Maxim Konovalov 277 February 07, 2019 08:40AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 325 February 08, 2019 05:42PM

Re: cache: move open to thread pool

karton 204 July 19, 2019 11:28AM

Re: cache: move open to thread pool

Maxim Konovalov 232 July 19, 2019 02:44PM

Re: cache: move open to thread pool

karton 188 July 19, 2019 09:46PM

Re: cache: move open to thread pool

Roman Arutyunyan 213 July 22, 2019 10:06AM

Re: cache: move open to thread pool

karton 210 July 22, 2019 11:40AM

Re: cache: move open to thread pool

karton 227 July 23, 2019 11:48PM

Re: cache: move open to thread pool

Roman Arutyunyan 253 August 16, 2019 10:26AM

Re: cache: move open to thread pool

karton 275 August 16, 2019 10:52AM

Re: cache: move open to thread pool

NCviQwilt 36 September 02, 2021 12:22PM

Re: cache: move open to thread pool

Roman Arutyunyan 21 September 09, 2021 06:50AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 75
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready