Welcome! Log In Create A New Profile

Advanced

RE: cache: move open to thread pool

August 28, 2018 05:18AM
Hi,

> Hi Eran,
>
> Happy to see that we are not the only place where we find open to be a problem. I took a look at your module and while the approach is sound, I decided the complexity doesn't seem to be worth it. Hope to see some numbers of how your module works at scale.
>
> - Ka-Hing
>
I don't have numbers that show the improvement we got from moving open to a thread pool,
but what I can say is that on our environment, open can sometimes take an unreasonable
time to complete - several seconds.
I noticed it several years ago, after I added a feature of 'performance counters' to my module
(posted it here - https://forum.nginx.org/read.php?2,255847,258854#msg-258854).
This is the reason I decided to implement the async open - in order to avoid having all
worker active requests hang for so long.
In my case, I was already using open file cache, and while I got a fairly good hit ratio,
these extreme cases of worker hanging for few seconds wasn't something I wanted to accept.
Also, in my setup, I'm not using proxy_cache - my servers serve as origin servers behind a CDN,
so a solution that is limited to file cache is not something I could use.

Eran
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 1040 August 07, 2018 05:28PM

Re: cache: move open to thread pool

Maxim Dounin 222 August 08, 2018 02:18PM

RE: cache: move open to thread pool

erankor 202 August 08, 2018 03:46PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 164 August 27, 2018 06:00PM

RE: cache: move open to thread pool

erankor 180 August 28, 2018 05:18AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 179 August 09, 2018 05:44PM

Re: cache: move open to thread pool

Maxim Dounin 526 August 10, 2018 07:42AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 157 August 27, 2018 05:40PM

Re: cache: move open to thread pool

Maxim Dounin 243 September 03, 2018 12:10PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 166 September 04, 2018 08:00PM

Re: cache: move open to thread pool

Maxim Dounin 172 September 13, 2018 02:12PM

Re: cache: move open to thread pool

Roman Arutyunyan 235 October 04, 2018 05:34AM

Re: cache: move open to thread pool

Roman Arutyunyan 302 November 01, 2018 08:30AM

Re: cache: move open to thread pool

Maxim Konovalov 162 November 01, 2018 12:08PM

Re: cache: move open to thread pool

Maxim Konovalov 176 November 08, 2018 09:20AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 155 November 15, 2018 05:54PM

Re: cache: move open to thread pool

Maxim Konovalov 168 November 16, 2018 04:12AM

Re: cache: move open to thread pool

Maxim Konovalov 171 December 05, 2018 04:44AM

Re: cache: move open to thread pool

Maxim Konovalov 128 January 10, 2019 03:32AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 140 January 14, 2019 08:54PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 113 January 22, 2019 01:22PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 135 January 22, 2019 02:36PM

Re: cache: move open to thread pool

Maxim Konovalov 127 January 23, 2019 07:40AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 112 February 06, 2019 04:20PM

Re: cache: move open to thread pool

Maxim Konovalov 118 February 07, 2019 08:40AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 157 February 08, 2019 05:42PM

Re: cache: move open to thread pool

karton 49 July 19, 2019 11:28AM

Re: cache: move open to thread pool

Maxim Konovalov 57 July 19, 2019 02:44PM

Re: cache: move open to thread pool

karton 49 July 19, 2019 09:46PM

Re: cache: move open to thread pool

Roman Arutyunyan 47 July 22, 2019 10:06AM

Re: cache: move open to thread pool

karton 52 July 22, 2019 11:40AM

Re: cache: move open to thread pool

karton 57 July 23, 2019 11:48PM

Re: cache: move open to thread pool

Roman Arutyunyan 35 August 16, 2019 10:26AM

Re: cache: move open to thread pool

karton 47 August 16, 2019 10:52AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 323
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready