Welcome! Log In Create A New Profile

Advanced

Re: cache: move open to thread pool

Roman Arutyunyan
July 22, 2019 10:06AM
Hi,

On Sat, Jul 20, 2019 at 09:44:25AM +0800, 洪志道 wrote:
> > The patch wasn't updated since that but I suspect it could be still
> applied to nginx, maybe with some minor tweaks.
>
> We still appreciate your work.
>
> BTW, are the patches in the attachment up to date?
> If not, can you share the latest patch?

We had no patches since november 1, 2018. The last patch is in this message:

http://mailman.nginx.org/pipermail/nginx-devel/2018-November/011538.html

> We are happy to apply it and feedback if possible.
> When there are many static files and accesses, do you think it will works
> very well?

We didn't have much feedback so far. So we would definitely appreciate your
contribution to testing it.

> On Sat, Jul 20, 2019 at 2:42 AM Maxim Konovalov <maxim@nginx.com> wrote:
>
> > Hi hongzhidao,
> >
> > The patch wasn't merged as we didn't see much interest and real
> > technical feedback from potential testers.
> >
> > The code adds additional complexity to the nginx core with all
> > associated costs of maintaining the code virtually forever. In the
> > same time at this point it brings no measurable value to the
> > community. At least, we haven't seen any proofs that it does.
> >
> > The patch wasn't updated since that but I suspect it could be still
> > applied to nginx, maybe with some minor tweaks.
> >
> > Maxim
> >
> > On 19/07/2019 18:26, 洪志道 wrote:
> > > Hi.
> > > Will this patch be merged into the main branch?
> > > What is the latest patch? We can help with the test.
> > > Thanks.
> > >
> > > On Sat, Feb 9, 2019 at 6:40 AM Ka-Hing Cheung via nginx-devel
> > > <nginx-devel@nginx.org <mailto:nginx-devel@nginx.org>> wrote:
> > >
> > > Unfortunately our test colo is not setup to do performance testing
> > > (the traffic it receives varies too much). We do intend to merge
> > > this
> > > to our production colos but there's no timeline yet.
> > >
> > > Yuchen (CC'ed) will be the main contact from now on as today is my
> > > last day at Cloudflare.
> > >
> > > - Ka-Hing
> > >
> > > On Thu, Feb 7, 2019 at 5:39 AM Maxim Konovalov <maxim@nginx.com
> > > <mailto:maxim@nginx.com>> wrote:
> > > >
> > > > Great. Thanks for the testing!
> > > >
> > > > Did you see any measurable perf. metrics changes comparing to your
> > > > aio open implementation or comparing to nginx without aio open
> > > support?
> > > >
> > > > We are still waiting for additional input from another tester, who
> > > > expressed interest before.
> > > >
> > > > Thanks,
> > > >
> > > > Maxim
> > > >
> > > > On 07/02/2019 00:19, Ka-Hing Cheung wrote:
> > > > > This has been running in our test colo for the past week
> > > with no ill effects.
> > > > >
> > > > > On Wed, Jan 23, 2019 at 4:39 AM Maxim Konovalov
> > > <maxim@nginx.com <mailto:maxim@nginx.com>> wrote:
> > > > >>
> > > > >> Hi Ka-Hing,
> > > > >>
> > > > >> Roman told me that the delta is because of your changes.
> > > > >>
> > > > >> Thanks for your time on that. Waiting for your testing
> > > results.
> > > > >>
> > > > >> Maxim
> > > > >>
> > > > >> On 22/01/2019 22:34, Ka-Hing Cheung via nginx-devel wrote:
> > > > >>> I spoke too soon, just realized our test colo is running
> > > the patches
> > > > >>> without aio_open on. Flipping that switch now.
> > > > >>>
> > > > >>> Also, including the patch that we applied on top in
> > > addition to the
> > > > >>> massaging we did to resolve conflicts. I haven't dug too
> > > deep to see
> > > > >>> if stock nginx also requires similar changes or they are only
> > > > >>> necessary because of our other nginx changes:
> > > > >>>
> > > > >> [...]
> > > > >>
> > > > >> --
> > > > >> Maxim Konovalov
> > > >
> > > >
> > > > --
> > > > Maxim Konovalov
> > > _______________________________________________
> > > nginx-devel mailing list
> > > nginx-devel@nginx.org <mailto:nginx-devel@nginx.org>
> > > http://mailman.nginx.org/mailman/listinfo/nginx-devel
> > >
> > >
> > > _______________________________________________
> > > nginx-devel mailing list
> > > nginx-devel@nginx.org
> > > http://mailman.nginx.org/mailman/listinfo/nginx-devel
> > >
> >
> >
> > --
> > Maxim Konovalov
> >

> _______________________________________________
> nginx-devel mailing list
> nginx-devel@nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel


--
Roman Arutyunyan
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 956 August 07, 2018 05:28PM

Re: cache: move open to thread pool

Maxim Dounin 195 August 08, 2018 02:18PM

RE: cache: move open to thread pool

erankor 173 August 08, 2018 03:46PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 141 August 27, 2018 06:00PM

RE: cache: move open to thread pool

erankor 156 August 28, 2018 05:18AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 155 August 09, 2018 05:44PM

Re: cache: move open to thread pool

Maxim Dounin 158 August 10, 2018 07:42AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 133 August 27, 2018 05:40PM

Re: cache: move open to thread pool

Maxim Dounin 211 September 03, 2018 12:10PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 139 September 04, 2018 08:00PM

Re: cache: move open to thread pool

Maxim Dounin 148 September 13, 2018 02:12PM

Re: cache: move open to thread pool

Roman Arutyunyan 203 October 04, 2018 05:34AM

Re: cache: move open to thread pool

Roman Arutyunyan 275 November 01, 2018 08:30AM

Re: cache: move open to thread pool

Maxim Konovalov 140 November 01, 2018 12:08PM

Re: cache: move open to thread pool

Maxim Konovalov 152 November 08, 2018 09:20AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 132 November 15, 2018 05:54PM

Re: cache: move open to thread pool

Maxim Konovalov 144 November 16, 2018 04:12AM

Re: cache: move open to thread pool

Maxim Konovalov 146 December 05, 2018 04:44AM

Re: cache: move open to thread pool

Maxim Konovalov 107 January 10, 2019 03:32AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 115 January 14, 2019 08:54PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 88 January 22, 2019 01:22PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 113 January 22, 2019 02:36PM

Re: cache: move open to thread pool

Maxim Konovalov 103 January 23, 2019 07:40AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 85 February 06, 2019 04:20PM

Re: cache: move open to thread pool

Maxim Konovalov 93 February 07, 2019 08:40AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 134 February 08, 2019 05:42PM

Re: cache: move open to thread pool

karton 26 July 19, 2019 11:28AM

Re: cache: move open to thread pool

Maxim Konovalov 33 July 19, 2019 02:44PM

Re: cache: move open to thread pool

karton 27 July 19, 2019 09:46PM

Re: cache: move open to thread pool

Roman Arutyunyan 25 July 22, 2019 10:06AM

Re: cache: move open to thread pool

karton 26 July 22, 2019 11:40AM

Re: cache: move open to thread pool

karton 30 July 23, 2019 11:48PM

Re: cache: move open to thread pool

Roman Arutyunyan 10 August 16, 2019 10:26AM

Re: cache: move open to thread pool

karton 12 August 16, 2019 10:52AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 82
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready