Welcome! Log In Create A New Profile

Advanced

Re: cache: move open to thread pool

Maxim Konovalov
July 19, 2019 02:44PM
Hi hongzhidao,

The patch wasn't merged as we didn't see much interest and real
technical feedback from potential testers.

The code adds additional complexity to the nginx core with all
associated costs of maintaining the code virtually forever. In the
same time at this point it brings no measurable value to the
community. At least, we haven't seen any proofs that it does.

The patch wasn't updated since that but I suspect it could be still
applied to nginx, maybe with some minor tweaks.

Maxim

On 19/07/2019 18:26, 洪志道 wrote:
> Hi.
> Will this patch be merged into the main branch?
> What is the latest patch? We can help with the test.
> Thanks.
>
> On Sat, Feb 9, 2019 at 6:40 AM Ka-Hing Cheung via nginx-devel
> <nginx-devel@nginx.org <mailto:nginx-devel@nginx.org>> wrote:
>
> Unfortunately our test colo is not setup to do performance testing
> (the traffic it receives varies too much). We do intend to merge
> this
> to our production colos but there's no timeline yet.
>
> Yuchen (CC'ed) will be the main contact from now on as today is my
> last day at Cloudflare.
>
> - Ka-Hing
>
> On Thu, Feb 7, 2019 at 5:39 AM Maxim Konovalov <maxim@nginx.com
> <mailto:maxim@nginx.com>> wrote:
> >
> > Great.  Thanks for the testing!
> >
> > Did you see any measurable perf. metrics changes comparing to your
> > aio open implementation or comparing to nginx without aio open
> support?
> >
> > We are still waiting for additional input from another tester, who
> > expressed interest before.
> >
> > Thanks,
> >
> > Maxim
> >
> > On 07/02/2019 00:19, Ka-Hing Cheung wrote:
> > > This has been running in our test colo for the past week
> with no ill effects.
> > >
> > > On Wed, Jan 23, 2019 at 4:39 AM Maxim Konovalov
> <maxim@nginx.com <mailto:maxim@nginx.com>> wrote:
> > >>
> > >> Hi Ka-Hing,
> > >>
> > >> Roman told me that the delta is because of your changes.
> > >>
> > >> Thanks for your time on that.  Waiting for your testing
> results.
> > >>
> > >> Maxim
> > >>
> > >> On 22/01/2019 22:34, Ka-Hing Cheung via nginx-devel wrote:
> > >>> I spoke too soon, just realized our test colo is running
> the patches
> > >>> without aio_open on. Flipping that switch now.
> > >>>
> > >>> Also, including the patch that we applied on top in
> addition to the
> > >>> massaging we did to resolve conflicts. I haven't dug too
> deep to see
> > >>> if stock nginx also requires similar changes or they are only
> > >>> necessary because of our other nginx changes:
> > >>>
> > >> [...]
> > >>
> > >> --
> > >> Maxim Konovalov
> >
> >
> > --
> > Maxim Konovalov
> _______________________________________________
> nginx-devel mailing list
> nginx-devel@nginx.org <mailto:nginx-devel@nginx.org>
> http://mailman.nginx.org/mailman/listinfo/nginx-devel
>
>
> _______________________________________________
> nginx-devel mailing list
> nginx-devel@nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel
>


--
Maxim Konovalov
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 1012 August 07, 2018 05:28PM

Re: cache: move open to thread pool

Maxim Dounin 209 August 08, 2018 02:18PM

RE: cache: move open to thread pool

erankor 187 August 08, 2018 03:46PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 153 August 27, 2018 06:00PM

RE: cache: move open to thread pool

erankor 170 August 28, 2018 05:18AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 167 August 09, 2018 05:44PM

Re: cache: move open to thread pool

Maxim Dounin 517 August 10, 2018 07:42AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 146 August 27, 2018 05:40PM

Re: cache: move open to thread pool

Maxim Dounin 227 September 03, 2018 12:10PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 154 September 04, 2018 08:00PM

Re: cache: move open to thread pool

Maxim Dounin 161 September 13, 2018 02:12PM

Re: cache: move open to thread pool

Roman Arutyunyan 224 October 04, 2018 05:34AM

Re: cache: move open to thread pool

Roman Arutyunyan 292 November 01, 2018 08:30AM

Re: cache: move open to thread pool

Maxim Konovalov 152 November 01, 2018 12:08PM

Re: cache: move open to thread pool

Maxim Konovalov 165 November 08, 2018 09:20AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 144 November 15, 2018 05:54PM

Re: cache: move open to thread pool

Maxim Konovalov 156 November 16, 2018 04:12AM

Re: cache: move open to thread pool

Maxim Konovalov 161 December 05, 2018 04:44AM

Re: cache: move open to thread pool

Maxim Konovalov 119 January 10, 2019 03:32AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 129 January 14, 2019 08:54PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 103 January 22, 2019 01:22PM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 125 January 22, 2019 02:36PM

Re: cache: move open to thread pool

Maxim Konovalov 116 January 23, 2019 07:40AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 102 February 06, 2019 04:20PM

Re: cache: move open to thread pool

Maxim Konovalov 106 February 07, 2019 08:40AM

Re: cache: move open to thread pool

Ka-Hing Cheung via nginx-devel 148 February 08, 2019 05:42PM

Re: cache: move open to thread pool

karton 40 July 19, 2019 11:28AM

Re: cache: move open to thread pool

Maxim Konovalov 46 July 19, 2019 02:44PM

Re: cache: move open to thread pool

karton 40 July 19, 2019 09:46PM

Re: cache: move open to thread pool

Roman Arutyunyan 38 July 22, 2019 10:06AM

Re: cache: move open to thread pool

karton 40 July 22, 2019 11:40AM

Re: cache: move open to thread pool

karton 43 July 23, 2019 11:48PM

Re: cache: move open to thread pool

Roman Arutyunyan 24 August 16, 2019 10:26AM

Re: cache: move open to thread pool

karton 35 August 16, 2019 10:52AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 78
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready