Welcome! Log In Create A New Profile

Advanced

Re: [PATCH 2 of 4] QUIC: removed explicit packet padding for certain frames

Sergey Kandaurov
July 28, 2023 11:52AM
> On 6 Jul 2023, at 17:57, Roman Arutyunyan <arut@nginx.com> wrote:
>
> # HG changeset patch
> # User Roman Arutyunyan <arut@nginx.com>
> # Date 1688628647 -14400
> # Thu Jul 06 11:30:47 2023 +0400
> # Node ID f98ff9b62d2bccac10b603b8183eca2ff0f4183e
> # Parent df01e8582189126cd5defd8f4bb021fec1a1a35a
> QUIC: removed explicit packet padding for certain frames.
>
> The frames for which the padding is removed are PATH_CHALLENGE and
> PATH_RESPONSE, which are sent separately by ngx_quic_frame_sendto().

Looks good.

We discussed this in the past, this code seems to be dead.

>
> diff --git a/src/event/quic/ngx_event_quic_output.c b/src/event/quic/ngx_event_quic_output.c
> --- a/src/event/quic/ngx_event_quic_output.c
> +++ b/src/event/quic/ngx_event_quic_output.c
> @@ -525,7 +525,7 @@ ngx_quic_output_packet(ngx_connection_t
> ssize_t flen;
> ngx_str_t res;
> ngx_int_t rc;
> - ngx_uint_t nframes, expand;
> + ngx_uint_t nframes;
> ngx_msec_t now;
> ngx_queue_t *q;
> ngx_quic_frame_t *f;
> @@ -560,7 +560,6 @@ ngx_quic_output_packet(ngx_connection_t
> nframes = 0;
> p = src;
> len = 0;
> - expand = 0;
>
> for (q = ngx_queue_head(&ctx->frames);
> q != ngx_queue_sentinel(&ctx->frames);
> @@ -568,33 +567,6 @@ ngx_quic_output_packet(ngx_connection_t
> {
> f = ngx_queue_data(q, ngx_quic_frame_t, queue);
>
> - if (!expand && (f->type == NGX_QUIC_FT_PATH_RESPONSE
> - || f->type == NGX_QUIC_FT_PATH_CHALLENGE))
> - {
> - /*
> - * RFC 9000, 8.2.1. Initiating Path Validation
> - *
> - * An endpoint MUST expand datagrams that contain a
> - * PATH_CHALLENGE frame to at least the smallest allowed
> - * maximum datagram size of 1200 bytes...
> - *
> - * (same applies to PATH_RESPONSE frames)
> - */
> -
> - if (max < 1200) {
> - /* expanded packet will not fit */
> - break;
> - }
> -
> - if (min < 1200) {
> - min = 1200;
> -
> - min_payload = ngx_quic_payload_size(&pkt, min);
> - }
> -
> - expand = 1;
> - }
> -
> if (len >= max_payload) {
> break;
> }
> _______________________________________________
> nginx-devel mailing list
> nginx-devel@nginx.org
> https://mailman.nginx.org/mailman/listinfo/nginx-devel

--
Sergey Kandaurov
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH 0 of 3] QUIC path MTU discovery

Roman Arutyunyan 939 March 28, 2023 10:52AM

[PATCH 1 of 3] QUIC: changed path validation timeout

Roman Arutyunyan 149 March 28, 2023 10:52AM

Re: [PATCH 1 of 3] QUIC: changed path validation timeout

Sergey Kandaurov 162 April 24, 2023 08:16AM

Re: [PATCH 1 of 3] QUIC: changed path validation timeout

Roman Arutyunyan 129 May 03, 2023 09:02AM

Re: [PATCH 1 of 3] QUIC: changed path validation timeout

Sergey Kandaurov 102 May 09, 2023 06:12AM

Re: [PATCH 1 of 3] QUIC: changed path validation timeout

Sergey Kandaurov 114 May 09, 2023 09:00AM

Re: [PATCH 1 of 3] QUIC: changed path validation timeout

Sergey Kandaurov 112 May 09, 2023 11:08AM

Re: [PATCH 1 of 3] QUIC: changed path validation timeout

Roman Arutyunyan 128 May 09, 2023 11:30AM

[PATCH 2 of 3] QUIC: allowed ngx_quic_frame_sendto() to return NGX_AGAIN

Roman Arutyunyan 153 March 28, 2023 10:52AM

[PATCH 3 of 3] QUIC: path MTU discovery

Roman Arutyunyan 207 March 28, 2023 11:00AM

Re: [PATCH 3 of 3] QUIC: path MTU discovery

Sergey Kandaurov 140 May 01, 2023 01:00PM

Re: [PATCH 3 of 3] QUIC: path MTU discovery

Maxim Dounin 126 May 01, 2023 04:42PM

Re: [PATCH 3 of 3] QUIC: path MTU discovery

Roman Arutyunyan 132 May 08, 2023 08:16AM

Re: [PATCH 3 of 3] QUIC: path MTU discovery

Sergey Kandaurov 112 May 08, 2023 11:12AM

[PATCH 0 of 4] QUIC path MTU discovery

Roman Arutyunyan 86 July 06, 2023 09:58AM

[PATCH 1 of 4] QUIC: removed path->limited flag

Roman Arutyunyan 91 July 06, 2023 09:58AM

Re: [PATCH 1 of 4] QUIC: removed path->limited flag

Sergey Kandaurov 90 July 28, 2023 11:52AM

[PATCH 2 of 4] QUIC: removed explicit packet padding for certain frames

Roman Arutyunyan 90 July 06, 2023 09:58AM

Re: [PATCH 2 of 4] QUIC: removed explicit packet padding for certain frames

Sergey Kandaurov 82 July 28, 2023 11:52AM

[PATCH 3 of 4] QUIC: allowed ngx_quic_frame_sendto() to return NGX_AGAIN

Roman Arutyunyan 90 July 06, 2023 09:58AM

Re: [PATCH 3 of 4] QUIC: allowed ngx_quic_frame_sendto() to return NGX_AGAIN

Sergey Kandaurov 86 July 28, 2023 11:52AM

[PATCH 4 of 4] QUIC: path MTU discovery

Roman Arutyunyan 95 July 06, 2023 09:58AM

Re: [PATCH 4 of 4] QUIC: path MTU discovery

Roman Arutyunyan 96 July 07, 2023 04:00AM

Re: [PATCH 4 of 4] QUIC: path MTU discovery

Sergey Kandaurov 100 July 28, 2023 11:54AM

Re: [PATCH 4 of 4] QUIC: path MTU discovery

Roman Arutyunyan 93 July 31, 2023 01:36PM

Re: [PATCH 4 of 4] QUIC: path MTU discovery

Sergey Kandaurov 122 August 08, 2023 05:50AM

Re: [PATCH 4 of 4] QUIC: path MTU discovery

Roman Arutyunyan 92 August 10, 2023 06:22AM

Re: [PATCH 4 of 4] QUIC: path MTU discovery

Sergey Kandaurov 87 August 10, 2023 10:20AM

Re: [PATCH 4 of 4] QUIC: path MTU discovery

Roman Arutyunyan 105 August 14, 2023 09:54AM

Re: [PATCH 0 of 4] QUIC path MTU discovery

Sergey Kandaurov 86 July 28, 2023 11:52AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 329
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready