Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin
May 05, 2022 05:38PM
Hello!

On Thu, May 05, 2022 at 09:22:02AM +0500, RekGRpth wrote:

> 1) The proper way is use cleanup handler? Is this right?
> https://github.com/RekGRpth/ngx_pg_module/blob/25db8706e6268f8197002012e9044be64f698ef3/ngx_pg_module.c#L1422-L1424

Quick look suggests it should work.

> 2) Why my module is a hack by design?

As already outlined in previous responses, your module misuses
parts of the upstream module infrastructure, notably upstream
blocks and balancers, for its own needs. This is not something
supported: upstream module infrastructure is expected to be used
by the upstream module itself, and not arbitrary external modules.
What you are doing might (and likely will) stop working on any
non-trivial changes in the upstream module, even if there will be
no internal API changes.

--
Maxim Dounin
http://mdounin.ru/
_______________________________________________
nginx-devel mailing list -- nginx-devel@nginx.org
To unsubscribe send an email to nginx-devel-leave@nginx.org
Subject Author Views Posted

[PATCH] upstream keepalive: save and restore connection data

RekGRpth 519 April 30, 2022 01:04AM

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin 69 April 30, 2022 06:20PM

Re: [PATCH] upstream keepalive: save and restore connection data

RekGRpth 159 April 30, 2022 10:48PM

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin 101 May 01, 2022 11:56AM

Re: [PATCH] upstream keepalive: save and restore connection data

RekGRpth 76 May 01, 2022 11:44PM

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin 59 May 02, 2022 04:12PM

Re: [PATCH] upstream keepalive: save and restore connection data

RekGRpth 61 May 05, 2022 12:24AM

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin 110 May 05, 2022 05:38PM

Re: [PATCH] upstream keepalive: save and restore connection data

RekGRpth 64 May 05, 2022 11:40PM

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin 59 May 06, 2022 09:30AM

Re: [PATCH] upstream keepalive: save and restore connection data

RekGRpth 79 May 06, 2022 09:58AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 80
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready