Hello!

On Thu, May 05, 2022 at 09:22:02AM +0500, RekGRpth wrote:

> 1) The proper way is use cleanup handler? Is this right?
> https://github.com/RekGRpth/ngx_pg_module/blob/25db8706e6268f8197002012e9044be64f698ef3/ngx_pg_module.c#L1422-L1424

Quick look suggests it should work.

> 2) Why my module is a hack by design?

As already outlined in previous responses, your module misuses
parts of the upstream module infrastructure, notably upstream
blocks and balancers, for its own needs. This is not something
supported: upstream module infrastructure is expected to be used
by the upstream module itself, and not arbitrary external modules.
What you are doing might (and likely will) stop working on any
non-trivial changes in the upstream module, even if there will be
no internal API changes.

--
Maxim Dounin
http://mdounin.ru/
_______________________________________________
nginx-devel mailing list -- nginx-devel@nginx.org
To unsubscribe send an email to nginx-devel-leave@nginx.org