Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin
May 01, 2022 11:56AM
Hello!

On Sun, May 01, 2022 at 07:46:05AM +0500, RekGRpth wrote:

> now, for example, I do very dirty hack for this:
> https://github.com/RekGRpth/ngx_pg_module/blob/06eab53160fcff2b19e73ed5bc787f534c2a4c2e/ngx_pg_module.c#L1382-L1385
> for save and https://github.com/RekGRpth/ngx_pg_module/blob/06eab53160fcff2b19e73ed5bc787f534c2a4c2e/ngx_pg_module.c#L1362
> for restore

As far as I understand, the module in question misuses parts of
the upstream infrastructure, notably upstream blocks and
balancers, for its own needs. It looks somewhat strange to me to
request changes in the infrastructure which corresponds to the
misuse in question and not the use of the infrastructure in the
upstream module itself.

Either way, a better and well supported approach to save any
connection-specific data within a cached connection would be to do
so via a connection's pool cleanup, see gRPC proxy module for an
example:

http://hg.nginx.org/nginx/file/a736a7a613ea/src/http/modules/ngx_http_grpc_module.c#l4196

Hope this helps.

--
Maxim Dounin
http://mdounin.ru/
_______________________________________________
nginx-devel mailing list -- nginx-devel@nginx.org
To unsubscribe send an email to nginx-devel-leave@nginx.org
Subject Author Views Posted

[PATCH] upstream keepalive: save and restore connection data

RekGRpth 519 April 30, 2022 01:04AM

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin 69 April 30, 2022 06:20PM

Re: [PATCH] upstream keepalive: save and restore connection data

RekGRpth 159 April 30, 2022 10:48PM

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin 101 May 01, 2022 11:56AM

Re: [PATCH] upstream keepalive: save and restore connection data

RekGRpth 77 May 01, 2022 11:44PM

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin 59 May 02, 2022 04:12PM

Re: [PATCH] upstream keepalive: save and restore connection data

RekGRpth 62 May 05, 2022 12:24AM

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin 111 May 05, 2022 05:38PM

Re: [PATCH] upstream keepalive: save and restore connection data

RekGRpth 65 May 05, 2022 11:40PM

Re: [PATCH] upstream keepalive: save and restore connection data

Maxim Dounin 59 May 06, 2022 09:30AM

Re: [PATCH] upstream keepalive: save and restore connection data

RekGRpth 79 May 06, 2022 09:58AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 94
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready