On Monday 24 April 2017 15:48:25 Piotr Sikora via nginx-devel wrote:
> # HG changeset patch
> # User Piotr Sikora <piotrsikora@google.com>
> # Date 1493073310 25200
> # Mon Apr 24 15:35:10 2017 -0700
> # Node ID b8d7f4a4d5abb4a27a772910358e263d49c618ef
> # Parent a8cfd4c454ff5433629bfd16444c6c71ee932fa1
> HTTP/2: make SETTINGS ACK frame reusable.
>
> Signed-off-by: Piotr Sikora <piotrsikora@google.com>
>
[..]
> @@ -2495,8 +2503,8 @@ ngx_http_v2_send_settings(ngx_http_v2_co
> ngx_http_v2_srv_conf_t *h2scf;
> ngx_http_v2_out_frame_t *frame;
>
> - ngx_log_debug1(NGX_LOG_DEBUG_HTTP, h2c->connection->log, 0,
> - "http2 send SETTINGS frame ack:%ui", ack);
> + ngx_log_debug0(NGX_LOG_DEBUG_HTTP, h2c->connection->log, 0,
> + "http2 send SETTINGS frame params:3");
>
[..]

I'm pretty sure that this number will be forgotten to change after
adding new parameters.

Since in another patch you are suggesting to add debug messages to
print each parameter then they will be countable without a problem.

Let it be just:

ngx_log_debug0(NGX_LOG_DEBUG_HTTP, h2c->connection->log, 0,
"http2 send SETTINGS frame");


wbr, Valentin V. Bartenev

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel