Welcome! Log In Create A New Profile

Re: [PATCH 1 of 4] HTTP/2: emit new frames only after applying all SETTINGS params

Forum List Message List New Topic Print View

Piotr Sikora via nginx-devel

June 01, 2017 05:56PM

Hey Valentin,

> The new initial window size can be lower than the previous one,
> so the difference can be negative (that's why the delta parameter
> of ngx_http_v2_adjust_windows() is ssize_t).

Oops, good catch, thanks!

Funnily enough, the original patch worked just fine (at least on
systems where size of ssize_t was equal to size of ngx_uint_t), since
the value would overflow and result in the same negative number when
casted to ssize_t.

I updated patchset with suggested changes, please take a look.

Best regards,
Piotr Sikora
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel

Reply Quote

RSS

Subject	Author	Views	Posted
[PATCH 1 of 4] HTTP/2: emit new frames only after applying all SETTINGS params	Piotr Sikora via nginx-devel	497	April 24, 2017 06:50PM
[PATCH 3 of 4] HTTP/2: make SETTINGS ACK frame reusable	Piotr Sikora via nginx-devel	231	April 24, 2017 06:50PM
Re: [PATCH 3 of 4] HTTP/2: make SETTINGS ACK frame reusable	Valentin V. Bartenev	167	June 01, 2017 01:54PM
[PATCH 2 of 4] HTTP/2: send SETTINGS ACK after applying all SETTINGS params	Piotr Sikora via nginx-devel	260	April 24, 2017 06:50PM
Re: [PATCH 2 of 4] HTTP/2: send SETTINGS ACK after applying all SETTINGS params	Valentin V. Bartenev	193	June 01, 2017 01:24PM
[PATCH 4 of 4] HTTP/2: don't send SETTINGS ACK before already queued DATA frames	Piotr Sikora via nginx-devel	231	April 24, 2017 06:50PM
Re: [PATCH 4 of 4] HTTP/2: don't send SETTINGS ACK before already queued DATA frames	Valentin V. Bartenev	233	June 01, 2017 01:54PM
Re: [PATCH 1 of 4] HTTP/2: emit new frames only after applying all SETTINGS params	Piotr Sikora via nginx-devel	237	May 30, 2017 05:24PM
Re: [PATCH 1 of 4] HTTP/2: emit new frames only after applying all SETTINGS params	Valentin V. Bartenev	189	June 01, 2017 10:50AM
Re: [PATCH 1 of 4] HTTP/2: emit new frames only after applying all SETTINGS params	Valentin V. Bartenev	189	June 01, 2017 01:56PM
Re: [PATCH 1 of 4] HTTP/2: emit new frames only after applying all SETTINGS params	Piotr Sikora via nginx-devel	188	June 01, 2017 05:56PM
Re: [PATCH 1 of 4] HTTP/2: emit new frames only after applying all SETTINGS params	Valentin V. Bartenev	349	June 02, 2017 08:12AM
[PATCH 1 of 4] HTTP/2: emit new frames only after applying all SETTINGS params	Piotr Sikora via nginx-devel	208	June 01, 2017 05:54PM
[PATCH 2 of 4] HTTP/2: send SETTINGS ACK after applying all SETTINGS params	Piotr Sikora via nginx-devel	213	June 01, 2017 05:54PM
[PATCH 3 of 4] HTTP/2: make SETTINGS ACK frame reusable	Piotr Sikora via nginx-devel	244	June 01, 2017 05:54PM
[PATCH 4 of 4] HTTP/2: don't send SETTINGS ACK before already queued DATA frames	Piotr Sikora via nginx-devel	197	June 01, 2017 05:54PM

Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 260

Record Number of Users: 8 on April 13, 2023

Record Number of Guests: 421 on December 02, 2018