Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel
April 24, 2017 07:04PM
Hey Valentin,

> I actually agree with that, but let's try to reduce the size of printing.
>
> http2 send SETTINGS frame MAX_CONCURRENT_STREAMS
> http2 send SETTINGS frame INITIAL_WINDOW_SIZE
> http2 send SETTINGS frame MAX_FRAME_SIZE
>
> This looks like too verbose for just one SETTINGS frame.

What do you suggest instead? All 3 params in the same line?

http2 send SETTINGS frame MAX_CONCURRENT_STREAMS:%ui
INITIAL_WINDOW_SIZE:%uz MAX_FRAME_SIZE:%ud

What about receiving part, then? Do you want to put all 6 params in
the same line?

http2 recv SETTINGS frame HEADER_TABLE_SIZE:%ui (ignored)
ENABLE_PUSH:%ui (ignored) MAX_CONCURRENT_STREAMS:%ui (ignored)
INITIAL_WINDOW_SIZE:%ui MAX_FRAME_SIZE:%ui MAX_HEADER_LIST_SIZE:%ui
(ignored)

It makes this way less readable, IMHO.

> Also, literally
> reading these lines can be misinterpreted as sending multiple SETTINGS
> frames.

That's because you skipped the first line, i.e.:

http2 send SETTINGS frame params:3
http2 send SETTINGS frame MAX_CONCURRENT_STREAMS
http2 send SETTINGS frame INITIAL_WINDOW_SIZE
http2 send SETTINGS frame MAX_FRAME_SIZE

Best regards,
Piotr Sikora
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel 591 April 03, 2017 11:14PM

Re: [PATCH] HTTP/2: add debug logging of control frames

Valentin V. Bartenev 305 April 06, 2017 10:32AM

Re: [PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel 253 April 07, 2017 05:44PM

Re: [PATCH] HTTP/2: add debug logging of control frames

Valentin V. Bartenev 284 April 17, 2017 02:58PM

Re: [PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel 284 April 24, 2017 07:04PM

Re: [PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel 328 May 30, 2017 05:22PM

Re: [PATCH] HTTP/2: add debug logging of control frames

Valentin V. Bartenev 214 June 08, 2017 02:32PM

Re: [PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel 240 June 19, 2017 10:30AM

[PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel 240 June 19, 2017 10:30AM

[PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel 404 April 07, 2017 06:10PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 162
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready