Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel
June 19, 2017 10:30AM
Hey Valentin,

> Ok, I've already resigned myself to multiline output, but don't let it
> look like an another SETTINGS frame.
>
> IMHO, something like that will be good enough:
>
> http2 send SETTINGS frame
> http2 SETTINGS param MAX_CONCURRENT_STREAMS: 100
> http2 SETTINGS param INITIAL_WINDOW_SIZE: 65536
> http2 SETTINGS param MAX_FRAME_SIZE: 16777215

Done, with retained "send " prefix to differentiate params that we
send and receive.

I've also re-added params counter to the "send SETTINGS frame", by
setting "len" value a bit sooner, so that the number of params is
calculated and cannot be forgotten in subsequent commits.

Best regards,
Piotr Sikora
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel 588 April 03, 2017 11:14PM

Re: [PATCH] HTTP/2: add debug logging of control frames

Valentin V. Bartenev 305 April 06, 2017 10:32AM

Re: [PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel 252 April 07, 2017 05:44PM

Re: [PATCH] HTTP/2: add debug logging of control frames

Valentin V. Bartenev 282 April 17, 2017 02:58PM

Re: [PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel 284 April 24, 2017 07:04PM

Re: [PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel 328 May 30, 2017 05:22PM

Re: [PATCH] HTTP/2: add debug logging of control frames

Valentin V. Bartenev 211 June 08, 2017 02:32PM

Re: [PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel 239 June 19, 2017 10:30AM

[PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel 239 June 19, 2017 10:30AM

[PATCH] HTTP/2: add debug logging of control frames

Piotr Sikora via nginx-devel 403 April 07, 2017 06:10PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 214
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready