Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] HTTP: add support for trailers in HTTP responses

Piotr Sikora
August 18, 2016 09:14PM
Hey Maxim,

> By saying "most popular use case" you are talking about something
> real-world you are aware of?

Yes.

Furthermore, I'm aware of a few systems using NGINX that use either
ugly workarounds or are missing features exactly because NGINX doesn't
support trailers.

> And this probably an additional thing to consider when introducing
> trailers: right now nginx strips all trailers. Changing this may
> be a surprise for those who use trailers internally, if any.

This can be easily mitigated with "proxy_pass_trailers on|off".

> We've already talked about gRPC.

Yes, and I'm not sure why you keep ignoring it.

If it's because you assume that it has to be end-to-end HTTP/2 and as
such trailers aren't the main blocker, then there are reverse proxies
like grpc-gateway [1] (which, coincidentally, doesn't support
trailers), that convert HTTP/1.1 requests to a "pure" gRPC requests
and back... Lack of trailers in NGINX prevents people from writing
custom upstream gRPC module, which could provide similar functionality
in NGINX.

However, if it's because "it's Google pushing it's own library", then
it's neither good nor technical reason for rejecting trailers support.

[1] https://github.com/grpc-ecosystem/grpc-gateway

> Fetch API and Server Timing are
> just specifications being developed which allow use of trailers,
> not much different from HTTP/1.1 itself.

Well, they wouldn't be adding it if it was so useless, would they?

> On the other hand, here is a good discussion of trailers and their
> security in this Fetch API ticket:
>
> https://github.com/whatwg/fetch/issues/34

Yes, and the consensus is that there are no new security implications,
as long as you don't magically merge trailers with headers (which, as
previously stated, I have no intention of doing).

> And here is a linked HTTPbis ticket to reconsider "TE: trailers"
> as it looks unneded:
>
> https://github.com/httpwg/http11bis/issues/18
>
> This is somewhat in line with what I think about it, as previously
> discussed in this thread.

I can drop this requirement if you insist, but that's much less
conservative approach than NGINX usually takes and I expect that some
obscure HTTP clients will break because of lack of proper support for
trailer-part in chunked encoding.

> I'm still not convinced that trailers are needed. As previously
> said, this HTTP feature was mostly unused for 17 years, and
> this suggests something is wrong with the feature. So it may be a
> good idea to postpone this at least till some real user will
> appear.

You have real users commenting in this thread, why do you keep
ignoring them? Other people already expressed interest, commented on
their internal implementations and/or said that they use workarounds
because NGINX doesn't support trailers.

What more do you need?

> In either case, I do not think that added trailers should by
> itself change transfer encoding used and remove Content-Length.

Again, why this is an issue with trailers but it's not an issue with gzip?

Best regards,
Piotr Sikora

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Piotr Sikora 928 June 26, 2016 07:14PM

[PATCH 2 of 2] Headers filter: add "add_trailer" directive

Piotr Sikora 424 June 26, 2016 07:14PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Maxim Dounin 381 June 27, 2016 09:46AM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Piotr Sikora 388 June 27, 2016 10:38AM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

shuxinyang 458 June 27, 2016 01:06PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Piotr Sikora 362 June 27, 2016 01:14PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

shuxinyang 382 June 27, 2016 02:56PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Piotr Sikora 476 June 27, 2016 03:16PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

shuxinyang 392 June 27, 2016 06:04PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Piotr Sikora 357 June 27, 2016 07:18PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

shuxinyang 362 June 27, 2016 09:00PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Piotr Sikora 329 June 27, 2016 09:46PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Maxim Dounin 367 June 27, 2016 01:54PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Piotr Sikora 368 June 27, 2016 03:06PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Piotr Sikora 336 June 30, 2016 03:58PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Maxim Dounin 374 July 04, 2016 10:22AM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Piotr Sikora 369 July 06, 2016 05:04PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Maxim Dounin 355 July 07, 2016 11:02AM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Piotr Sikora 337 July 07, 2016 04:10PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Maxim Dounin 342 July 07, 2016 07:22PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Piotr Sikora 393 July 13, 2016 01:28PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Maxim Dounin 406 July 13, 2016 02:44PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Piotr Sikora 314 July 13, 2016 08:36PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Alexey Ivanov 338 July 20, 2016 06:36PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Maxim Dounin 318 July 20, 2016 09:24PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Alexey Ivanov 347 July 20, 2016 09:34PM

Re: [PATCH 1 of 2] HTTP: add support for trailers in HTTP responses

Maxim Dounin 423 July 21, 2016 09:46AM

[PATCH] HTTP: add support for trailers in HTTP responses

Piotr Sikora 324 August 01, 2016 01:00AM

Re: [PATCH] HTTP: add support for trailers in HTTP responses

Piotr Sikora 312 August 01, 2016 03:36AM

Re: [PATCH] HTTP: add support for trailers in HTTP responses

Maxim Dounin 284 August 01, 2016 09:24AM

Re: [PATCH] HTTP: add support for trailers in HTTP responses

Piotr Sikora 444 August 01, 2016 01:58PM

Re: [PATCH] HTTP: add support for trailers in HTTP responses

Maxim Dounin 342 August 03, 2016 10:26PM

Re: [PATCH] HTTP: add support for trailers in HTTP responses

Piotr Sikora 298 August 18, 2016 09:14PM

Re: [PATCH] HTTP: add support for trailers in HTTP responses

Valentin V. Bartenev 293 August 19, 2016 07:16AM

Re: [PATCH] HTTP: add support for trailers in HTTP responses

Maxim Dounin 295 August 23, 2016 11:00AM

Re: [PATCH] HTTP: add support for trailers in HTTP responses

Maxim Dounin 510 August 23, 2016 10:24AM

Re: [PATCH] HTTP: add support for trailers in HTTP responses

Piotr Sikora 973 August 31, 2016 09:32PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 86
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready