Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Fixing an obvious segfault in ngx_http_upstream

May 05, 2010 03:40AM
On Tue, May 04, 2010 at 10:38:20AM +0800, agentzh wrote:

> On Tue, May 4, 2010 at 3:11 AM, Igor Sysoev <igor@sysoev.ru> wrote:
> >
> > You should test u->cleanup before *u->cleanup = NULL.
> > This code has appeared in 0.8.33:
> >
>
> Hi, Igor,
>
> It is *YOU* who didn't test u->cleanup before *u->cleanup in
> ngx_http_upstream_create ;)
>
> Please read my patch more carefully. To emphasize, in
> ngx_http_upstream_create, the ngx_http_upstream_cleanup call first
> clears u->cleanup but you later set *u->cleanup to NULL, which leads
> to segfault.
>
> There's no code written by myself, all in your nginx core ;)
>
> I don't see how it is relevant to your fastcgi fixes in 0.8.33. This
> bug appeared at least in nginx 0.8.29 :)

Yes, thank you, this is my fault.
Strangely, I did not see segfaults on my production servers.
What name should I write in CHANGES - Yichun Zhang or Agent Zhang ?


--
Igor Sysoev
http://sysoev.ru/en/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Fixing an obvious segfault in ngx_http_upstream

agentzh 2697 April 30, 2010 11:46PM

Re: [PATCH] Fixing an obvious segfault in ngx_http_upstream

Igor Sysoev 1074 May 03, 2010 03:12PM

Re: [PATCH] Fixing an obvious segfault in ngx_http_upstream

agentzh 1032 May 03, 2010 10:40PM

Re: [PATCH] Fixing an obvious segfault in ngx_http_upstream

Igor Sysoev 1146 May 05, 2010 03:40AM

Re: [PATCH] Fixing an obvious segfault in ngx_http_upstream

agentzh 1147 May 05, 2010 03:46AM

Re: [PATCH] Fixing an obvious segfault in ngx_http_upstream

Maxim Dounin 1040 May 05, 2010 05:20AM

Re: [PATCH] Fixing an obvious segfault in ngx_http_upstream

Igor Sysoev 1088 May 14, 2010 05:32AM

Re: [PATCH] Fixing an obvious segfault in ngx_http_upstream

Maxim Dounin 1002 May 14, 2010 08:40AM

Re: [PATCH] Fixing an obvious segfault in ngx_http_upstream

Igor Sysoev 1189 May 14, 2010 08:50AM

Re: [PATCH] Fixing an obvious segfault in ngx_http_upstream

agentzh 1272 June 07, 2010 05:40AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 73
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready