Maxim Dounin
April 11, 2010 06:42PM
Hello!

On Sun, Apr 11, 2010 at 09:20:17PM +0200, Matthias-Christian Ott wrote:

> Hi,
>
> it took a while to find the bug, but the patch is trivial:
>
> --- src/core/ngx_cycle.c~ 2009-10-26 17:22:24.000000000 +0100
> +++ src/core/ngx_cycle.c 2010-04-11 21:14:43.997932783 +0200
> @@ -847,7 +847,7 @@
> sin61 = (struct sockaddr_in6 *) sa1;
> sin62 = (struct sockaddr_in6 *) sa2;
>
> - if (sin61->sin6_port != sin61->sin6_port) {
> + if (sin61->sin6_port != sin62->sin6_port) {
> return NGX_DECLINED;
> }
>
> Without the patch reloading will fail, because nginx thinks the two IPv6
> addresses are the same regardless of the port.

Good catch, thanks.

Maxim Dounin

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

epoll_ctl failed (17: File exists)

Matthias-Christian Ott 5127 April 10, 2010 12:48AM

Re: epoll_ctl failed (17: File exists)

Matthias-Christian Ott 1535 April 10, 2010 12:46PM

Re: epoll_ctl failed (17: File exists)

Matthias-Christian Ott 1477 April 11, 2010 03:22PM

Re: epoll_ctl failed (17: File exists)

Maxim Dounin 1654 April 11, 2010 06:42PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 232
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready