On Wed, 6 Mar 2024 19:36:32 +0400
Sergey Kandaurov <pluknet@nginx.com> wrote:

> > On 28 Feb 2024, at 05:24, Piotr Sikora via nginx-devel <nginx-devel@nginx.org> wrote:
> >
> > # HG changeset patch
> > # User Piotr Sikora <piotr@aviatrix.com>
> > # Date 1708977643 0
> > # Mon Feb 26 20:00:43 2024 +0000
> > # Branch patch017
> > # Node ID dd95daa55cf6131a7e845edd6ad3b429bcef6f98
> > # Parent bb99cbe3a343ae581d2369b990aee66e69679ca2
> > Configure: add support for Homebrew on Apple Silicon.
>
> >
> > Signed-off-by: Piotr Sikora <piotr@aviatrix.com>
>
> Well, this is weird to pick up install prefix depending on the device.
> Hopefully, maintainers will rethink. Though given the relevant
> issue #9177 on githab is over 3 years, they would rather not.
>
> An obvious question is why do you need this change. Homebrew seems
> to be quite niche to pay attention. Using appropriate paths in
> --with-cc-opt / --with-ld-opt should work (not tested).
> If it really harms though, I think the change should go in.
>
> >
> > diff -r bb99cbe3a343 -r dd95daa55cf6 auto/lib/geoip/conf
> > --- a/auto/lib/geoip/conf Mon Feb 26 20:00:42 2024 +0000
> > +++ b/auto/lib/geoip/conf Mon Feb 26 20:00:43 2024 +0000
>
> A quick grep for MacPorts search paths suggests that some libraries
> are missing in the change. If this is on purpose, please reflect
> this in the description.
>
> > @@ -64,6 +64,23 @@
> > fi
> >
> >
> > +if [ $ngx_found = no ]; then
> > +
> > + # Homebrew on Apple Silicon
>
> Apple Silicon is something from the marketing language,
> using Apple ARM instead should be fine.
>
> Notably, Homebrew uses Hardware::CPU.arm Ruby language boolean
> to make the distinction.
>
> Further, given the smooth decay on Intel-based hardware,
> I'd reduce this just to "Homebrew".
>

It might be worth it to keep at least 'Apple' distinction in there, if
this will be added; Homebrew also supports Linux too, and installs to
/home/linuxbrew/.linuxbrew as default prefix path...

https://docs.brew.sh/Homebrew-on-Linux

> [..]
>
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel