Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] macOS: detect cache line size at runtime

Sergey Kandaurov
March 27, 2024 01:54PM
> On 21 Mar 2024, at 11:19, Piotr Sikora via nginx-devel <nginx-devel@nginx.org> wrote:
>
> Hi Sergey,
>
>> I prefer not to introduce more ad-hoc prefixes in the log summary.
>> Something like moving the "macOS" part to the end should be fine.
>
> That's fine with me.
>
>> style: this breaks a perfect indentation of two spaces after type;
>> further, it appears to be unsorted by type; I'd put it after u_long
>
> Good catch, thanks!
>
>> This makes the following slight update to the patch.
>> If you're okey with it, I will commit it then.
>
> LGTM.
>

Pushed the updated patch, thanks.

--
Sergey Kandaurov
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] macOS: detect cache line size at runtime

Piotr Sikora via nginx-devel 258 February 27, 2024 08:26PM

Re: [PATCH] macOS: detect cache line size at runtime

Sergey Kandaurov 10 March 20, 2024 08:16AM

Re: [PATCH] macOS: detect cache line size at runtime

Piotr Sikora via nginx-devel 11 March 21, 2024 03:20AM

Re: [PATCH] macOS: detect cache line size at runtime

Sergey Kandaurov 25 March 27, 2024 01:54PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 283
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready