Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Core: free connections and read/write events at shutdown

Piotr Sikora via nginx-devel
March 21, 2024 02:46AM
Hi Sergey,

> While I agree that false positives do not allow to run LeakSanitizer
> in a clean fashion, I don't think it is nginx which should be fixed.
> Rather, sanitizer analysis could be improved instead to prevent FPs.

Patches welcome?

> Meanwhile, leak sanitizer can be used with suppressions as appropriate
> to run tests cleanly. For example, this allows to suppress memory leak
> reports for allocations made during worker process init, such as cycle
> connections and read/write events:
>
> $ cat suppr.txt
> leak:ngx_worker_process_init
> $ LSAN_OPTIONS=suppressions=suppr.txt prove -r

Right, but that's an unnecessary step that prevents potential contributors
from using LeakSanitizer with NGINX. Also, I don't think that you're using
those tools either, likely because of those few false positives.

Best regards,
Piotr Sikora
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Core: free connections and read/write events at shutdown

Piotr Sikora via nginx-devel 208 February 27, 2024 08:22PM

Re: [PATCH] Core: free connections and read/write events at shutdown

Sergey Kandaurov 32 March 07, 2024 10:48AM

Re: [PATCH] Core: free connections and read/write events at shutdown

Piotr Sikora via nginx-devel 34 March 08, 2024 10:46AM

Re: [PATCH] Core: free connections and read/write events at shutdown

Sergey Kandaurov 21 March 15, 2024 12:20PM

Re: [PATCH] Core: free connections and read/write events at shutdown

Piotr Sikora via nginx-devel 25 March 21, 2024 02:46AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 171
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready