Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] fastcgi_params: added REMOTE_HOST parameter

Jakub Zelenka
January 12, 2024 06:06PM
Hi,

On Fri, Jan 12, 2024 at 10:20 PM Maxim Dounin <mdounin@mdounin.ru> wrote:

> > # HG changeset patch
> > # User Jakub Zelenka <bukka@php.net>
> > # Date 1705078404 0
> > # Fri Jan 12 16:53:24 2024 +0000
> > # Node ID 1ff2f737bd318a730d0944a6037c8fd7c7da2656
> > # Parent ee40e2b1d0833b46128a357fbc84c6e23be9be07
> > Added REMOTE_HOST parameter to fastcgi_params.
> >
> > When HTTP/3 is used, users will no longer get HTTP_HOST as host header
> is no
> > longer set by most clients. It is useful / necessary for many setups to
> have
> > such information and REMOTE_HOST is defined in CGI/1.1 for such purpose..
>
> https://datatracker.ietf.org/doc/html/rfc3875#section-4.1.9
>
> The REMOTE_HOST variable contains the fully qualified domain name of
> the client sending the request to the server, if available, otherwise
> NULL.
>
> That is, REMOTE_HOST is completely unrelated. It is not the
> hostname of the requested server, but the hostname of the client -
> result of a reverse DNS lookup of a client's IP address, something
> used to be provided by some servers when Internet was small (e.g,
> HostnameLookups in Apache). It is certainly not the right param
> to use for $host.
>
>
I think you are right. I somehow thought about nginx as a client for some
reason (technically it's a client from FPM point of view) but I agree that
the meaning is different here.

IMO, proper param to use would be SERVER_NAME. It is set to
> $server_name by default, though can be modified locally to provide
> $host if needed in the particular configuration.


I think it's probably the best option. Although current default value is a
bit unfortunate as it's just server_name specified by user so most of the
time is meaningless. Not sure if it can really comply with linked RFC
either as it doesn't have to be hostname. On the other side it's been
default for ages so I guess it won't be changed, right?

It's all just a bit unfortunate because with HTTP/3, there is no longer any
server host info in the default configuration that would be passed to FPM.

Cheers

Jakub
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] fastcgi_params: added REMOTE_HOST parameter

Jakub Zelenka 204 January 12, 2024 12:06PM

Re: [PATCH] fastcgi_params: added REMOTE_HOST parameter

Maxim Dounin 40 January 12, 2024 05:22PM

Re: [PATCH] fastcgi_params: added REMOTE_HOST parameter

Jakub Zelenka 37 January 12, 2024 06:06PM

Re: [PATCH] fastcgi_params: added REMOTE_HOST parameter

Maxim Dounin 53 January 12, 2024 10:16PM

Re: [PATCH] fastcgi_params: added REMOTE_HOST parameter

Jakub Zelenka 50 January 17, 2024 08:38AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 142
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready