On Thu, Dec 14, 2023 at 10:22:24AM +0400, Roman Arutyunyan wrote:
> Hi,
>
> On Wed, Dec 13, 2023 at 05:40:09PM +0400, Sergey Kandaurov wrote:
> > [..]
> >
> > This introduces accept_filter, deferred_accept, and setfib fields,
> > which is out of scope of this change. Anyway, this is useless
> > without corresponding support in ngx_stream_core_listen().
>
> We need to catch up with all such missing functionality in Stream in future.
Ok, let's postpone such unrelated changes in to separate patches.
[..]
> >
> > Note that stream (as well as mail) consistently uses sslcf naming
> > for keeping ssl configuration, unlike in http. Probably it makes
> > sense for a separate sweeping change with renaming sslcf to sscf.
>
> Agree. Also, it makes sense to rename ngx_stream_ssl_conf_t to
> ngx_stream_ssl_srv_conf_t.
Ok.
>
> You lost "c" in ngx_pcalloc() for no apparent reason.
No idea how's that happenned, thanks for catching.
[..]
> > @@ -463,7 +470,7 @@ ngx_stream_ssl_servername(ngx_ssl_conn_t
> > const char *servername;
> > ngx_connection_t *c;
> > ngx_stream_session_t *s;
> > - ngx_stream_ssl_conf_t *sscf;
> > + ngx_stream_ssl_conf_t *sslcf;
>
> Why? I though, you like "sscf" more :)
> I suggest that we use the better name "sscf" here.
Just to be clear, I used sslcf for consistency within current stream code,
but personally I agree to change this to sscf everywhere.
>
> New patch attached.
>
> --
> Roman Arutyunyan
> # HG changeset patch
> # User Roman Arutyunyan <arut@nginx.com>
> # Date 1702532489 -14400
> # Thu Dec 14 09:41:29 2023 +0400
> # Node ID a390e18b664e7ba678417ef6e40d94c37e89c2f7
> # Parent 844486cdd43a32d10b78493d7e7b80e9e2239d7e
> Stream: virtual servers.
>
> Server name is taken either from ngx_stream_ssl_module or
> ngx_stream_ssl_preread_module.
>
> The change adds "default" parameter to the "listen" directive, as well as the
the "default_server" parameter ?
> following directives: "server_names_hash_max_size",
> "server_names_hash_bucket_size", "server_name" and "ssl_reject_handshake".
Otherwise, looks good.
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel
