Welcome! Log In Create A New Profile

Re: [PATCH 3 of 3] HTTP/2: "http2" directive

Forum List Message List New Topic Print View

Maxim Dounin

January 29, 2023 08:30PM

Hello!

On Thu, Jan 26, 2023 at 03:50:47PM +0400, Roman Arutyunyan wrote:

> # HG changeset patch
> # User Roman Arutyunyan <arut@nginx.com>
> # Date 1674649725 -14400
> # Wed Jan 25 16:28:45 2023 +0400
> # Branch quic
> # Node ID 819737783463d7e38ea80109a976db1d3a9bb2db
> # Parent 555913c358221f647bbace26165bef5eb614add4
> HTTP/2: "http2" directive.
>
> The directive enables HTTP/2 in the current server. The previous way to
> enable HTTP/2 via "listen ... http2" is now deprecated.

In no particular order:

- The ngx_http_try_v2() should be a separate patch?

- The "(buf[0] == 'P')" check is not going to work, since valid
HTTP/1.x request can start with 'P' ('POST', 'PATCH', et
cetera). This needs better checking. Further, it's not
guaranteed to arrive in a single packet.

- Virtual servers (and 421), see comments to the first patch.

--
Maxim Dounin
http://mdounin.ru/
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel

Reply Quote

RSS

Subject	Author	Views	Posted
[PATCH 0 of 3] Directives for enabling http2 and http3	Roman Arutyunyan	872	January 26, 2023 06:52AM
[PATCH 1 of 3] HTTP/3: "quic" parameter of "listen" directive	Roman Arutyunyan	237	January 26, 2023 06:52AM
Re: [PATCH 1 of 3] HTTP/3: "quic" parameter of "listen" directive	Maxim Dounin	205	January 29, 2023 08:28PM
[PATCH 2 of 3] HTTP/3: trigger more compatibility errors for "listen quic"	Roman Arutyunyan	198	January 26, 2023 06:52AM
Re: [PATCH 2 of 3] HTTP/3: trigger more compatibility errors for "listen quic"	Maxim Dounin	153	January 29, 2023 08:28PM
[PATCH 3 of 3] HTTP/2: "http2" directive	Roman Arutyunyan	400	January 26, 2023 06:52AM
Re: [PATCH 3 of 3] HTTP/2: "http2" directive	Maxim Dounin	152	January 29, 2023 08:30PM
[PATCH 0 of 3] Directives for enabling http2 and http3	Roman Arutyunyan	146	February 01, 2023 09:02AM
[PATCH 1 of 3] HTTP/3: "quic" parameter of "listen" directive	Roman Arutyunyan	139	February 01, 2023 09:02AM
Re: [PATCH 1 of 3] HTTP/3: "quic" parameter of "listen" directive	Liam Crilly via nginx-devel	209	February 01, 2023 09:20AM
Re: [PATCH 1 of 3] HTTP/3: "quic" parameter of "listen" directive	Roman Arutyunyan	256	February 01, 2023 09:26AM
Re: [PATCH 1 of 3] HTTP/3: "quic" parameter of "listen" directive	Sergey Kandaurov	165	February 06, 2023 10:28AM
Re: [PATCH 1 of 3] HTTP/3: "quic" parameter of "listen" directive	Maxim Dounin	188	February 06, 2023 10:14PM
Re: [PATCH 1 of 3] HTTP/3: "quic" parameter of "listen" directive	Roman Arutyunyan	141	February 07, 2023 08:40AM
[PATCH 2 of 3] HTTP/2: "http2" directive	Roman Arutyunyan	140	February 01, 2023 09:02AM
Re: [PATCH 2 of 3] HTTP/2: "http2" directive	Maxim Dounin	195	February 06, 2023 10:14PM
Re: [PATCH 2 of 3] HTTP/2: "http2" directive	Roman Arutyunyan	171	February 07, 2023 09:06AM
Re: [PATCH 2 of 3] HTTP/2: "http2" directive	Sergey Kandaurov	143	February 07, 2023 05:26AM
Re: [PATCH 2 of 3] HTTP/2: "http2" directive	Roman Arutyunyan	211	February 07, 2023 08:46AM
[PATCH 3 of 3] HTTP/3: trigger more compatibility errors for "listen quic"	Roman Arutyunyan	166	February 01, 2023 09:02AM
[PATCH 0 of 3] Directives for enabling http2 and http3	Roman Arutyunyan	143	February 07, 2023 09:52AM
[PATCH 1 of 3] HTTP/3: "quic" parameter of "listen" directive	Roman Arutyunyan	283	February 07, 2023 09:52AM
[PATCH 2 of 3] HTTP/2: "http2" directive	Roman Arutyunyan	488	February 07, 2023 09:52AM
Re: [PATCH 2 of 3] HTTP/2: "http2" directive	Sergey Kandaurov	150	February 09, 2023 06:30AM
Re: [PATCH 2 of 3] HTTP/2: "http2" directive	Roman Arutyunyan	165	February 09, 2023 07:04AM
Re: [PATCH 2 of 3] HTTP/2: "http2" directive	Roman Arutyunyan	145	February 09, 2023 07:34AM
Re: [PATCH 2 of 3] HTTP/2: "http2" directive	Sergey Kandaurov	169	February 09, 2023 10:58AM
Re: [PATCH 2 of 3] HTTP/2: "http2" directive	Roman Arutyunyan	111	May 16, 2023 08:40AM
Re: [PATCH 2 of 3] HTTP/2: "http2" directive	Sergey Kandaurov	111	May 30, 2023 09:56AM
Re: [PATCH 2 of 3] HTTP/2: "http2" directive	Maxim Dounin	114	June 02, 2023 05:38PM
Re: [PATCH 2 of 3] HTTP/2: "http2" directive	Roman Arutyunyan	96	June 05, 2023 10:20AM
Re: [PATCH 2 of 3] HTTP/2: "http2" directive	Maxim Dounin	113	June 07, 2023 11:52AM
[PATCH 3 of 3] HTTP/3: trigger more compatibility errors for "listen quic"	Roman Arutyunyan	189	February 07, 2023 09:52AM
Re: [PATCH 0 of 3] Directives for enabling http2 and http3	Sergey Kandaurov	153	February 08, 2023 10:24AM

Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 264

Record Number of Users: 8 on April 13, 2023

Record Number of Guests: 421 on December 02, 2018