Forum List Message List New Topic Print View

Roman Arutyunyan

January 10, 2023 08:30AM

# HG changeset patch
# User Roman Arutyunyan <arut@nginx.com>
# Date 1672928146 -14400
# Thu Jan 05 18:15:46 2023 +0400
# Branch quic
# Node ID 7358ff656a6b124166926c026a13ec3057b6db6b
# Parent 18cc0fb5509d09d241d1235c754031304fa51685
HTTP/3: trigger 400 (Bad Request) on stream error while blocked.

Previously, stream was closed with NGX_HTTP_CLOSE. However, in a similar case
when recv() returns eof or error, status 400 is triggered.

diff --git a/src/http/v3/ngx_http_v3_request.c b/src/http/v3/ngx_http_v3_request.c
--- a/src/http/v3/ngx_http_v3_request.c
+++ b/src/http/v3/ngx_http_v3_request.c
@@ -554,7 +554,7 @@ ngx_http_v3_process_request(ngx_event_t

if (rc == NGX_BUSY) {
if (rev->error) {
- ngx_http_close_request(r, NGX_HTTP_CLOSE);
+ ngx_http_finalize_request(r, NGX_HTTP_BAD_REQUEST);
break;
}

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel

Reply Quote

RSS

Subject	Author	Views	Posted
[PATCH 0 of 3] HTTP/3 insert count block improvements	Roman Arutyunyan	435	January 05, 2023 10:32AM
[PATCH 1 of 3] QUIC: set stream error flag on reset	Roman Arutyunyan	82	January 05, 2023 10:32AM
Re: [PATCH 1 of 3] QUIC: set stream error flag on reset	Sergey Kandaurov	81	January 06, 2023 06:18AM
[PATCH 2 of 3] HTTP/3: trigger 400 (Bad Request) on stream error while blocked	Roman Arutyunyan	92	January 05, 2023 10:32AM
[PATCH 3 of 3] HTTP/3: insert count block timeout	Roman Arutyunyan	102	January 05, 2023 10:32AM
[PATCH 0 of 4] HTTP/3 insert count block improvements	Roman Arutyunyan	82	January 10, 2023 08:30AM
[PATCH 1 of 4] QUIC: automatically add and never delete stream events	Roman Arutyunyan	91	January 10, 2023 08:30AM
[PATCH 2 of 4] QUIC: set stream error flag on reset	Roman Arutyunyan	90	January 10, 2023 08:30AM
[PATCH 3 of 4] HTTP/3: trigger 400 (Bad Request) on stream error while blocked	Roman Arutyunyan	87	January 10, 2023 08:30AM
[PATCH 4 of 4] HTTP/3: insert count block timeout	Roman Arutyunyan	84	January 10, 2023 08:30AM
Re: [PATCH 0 of 4] HTTP/3 insert count block improvements	Sergey Kandaurov	119	January 10, 2023 08:40AM

Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 223

Record Number of Users: 8 on April 13, 2023

Record Number of Guests: 421 on December 02, 2018