Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Fixed port ranges support in the listen directive

Sergey Kandaurov
December 23, 2022 10:28AM
> On 18 Dec 2022, at 22:36, Valentin V. Bartenev <vbart@wbsrv.ru> wrote:
>
> # HG changeset patch
> # User Valentin Bartenev <vbart@wbsrv.ru>
> # Date 1671388142 -10800
> # Sun Dec 18 21:29:02 2022 +0300
> # Node ID 2af1287d2da744335932f6dca345618f7b80d1c1
> # Parent 3108d4d668e4b907868b815f0441d4c893bf4188
> Fixed port ranges support in the listen directive.
>
> Ports difference must be respected when checking addresses for duplicates,
> otherwise configurations like this are broken:
>
> listen 127.0.0.1:6000-6005
>
> It was broken by 4cc2bfeff46c (nginx 1.23.3).
>

Thanks for the report, the patch looks good, pushed.

It could've been caught by tests, if they were not skipped by default
due to using wildcard addresses (as you recall, changes went there too),
a measure to prevent from running on a box with external addresses.
Nowadays, it is rather historic, it's much easier to setup an isolated
environment. Probably it's time to move on to 21st century and start
running nginx tests with wildcard listening sockets unconditionally.
Meanwhile, I've made some changes to have a better chance to catch this.

--
Sergey Kandaurov
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Fixed port ranges support in the listen directive

Valentin V. Bartenev 517 December 18, 2022 01:40PM

Re: [PATCH] Fixed port ranges support in the listen directive

Maxim Dounin 99 December 18, 2022 06:50PM

Re: [PATCH] Fixed port ranges support in the listen directive

Sergey Kandaurov 145 December 23, 2022 10:28AM

Re: [PATCH] Fixed port ranges support in the listen directive

Maxim Dounin 138 December 26, 2022 05:58PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 186
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready