Hello!

On Wed, Dec 21, 2022 at 01:49:41AM +0400, Sergey Kandaurov wrote:

>
> > On 18 Dec 2022, at 00:01, Maxim Dounin <mdounin@mdounin.ru> wrote:
> >
> > # HG changeset patch
> > # User Maxim Dounin <mdounin@mdounin.ru>
> > # Date 1671306987 -10800
> > # Sat Dec 17 22:56:27 2022 +0300
> > # Node ID d3b64770c1e78fa5cef907c35904b21fb8b8e281
> > # Parent 3108d4d668e4b907868b815f0441d4c893bf4188
> > Updated link to OpenVZ suspend/resume bug.
> >
> > diff --git a/src/core/ngx_connection.c b/src/core/ngx_connection.c
> > --- a/src/core/ngx_connection.c
> > +++ b/src/core/ngx_connection.c
> > @@ -660,7 +660,7 @@ ngx_open_listening_sockets(ngx_cycle_t *
> > /*
> > * on OpenVZ after suspend/resume EADDRINUSE
> > * may be returned by listen() instead of bind(), see
> > - * https://bugzilla.openvz.org/show_bug.cgi?id=2470
> > + * https://bugs.openvz.org/browse/OVZ-5587
> > */
> >
> > if (err != NGX_EADDRINUSE || !ngx_test_config) {
>
> Looks good.

Pushed to http://mdounin.ru/hg/nginx.

> On a related note, I wonder if the bug was ever fixed.

That was how I've found out that the old link is no longer
relevant.

> Looking at the bug tracker, it seems not.
> OTOH, the bug manifested on linux 2.6.32, while
> "OpenVZ can work with unpatched Linux 3.x kernels" (c).
> Anyway, the workaround doesn't seem to have noticeable
> maintenance costs.

AFAIK, on unpatched kernels OpenVZ works with various limitations,
and it might simply do not support suspend/resume.

My impression is that the bug is still there, and the workaround
is still needed.

Either way, I think we can keep the workaround for some additional
time.

--
Maxim Dounin
http://mdounin.ru/
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel