Welcome! Log In Create A New Profile

Advanced

[nginx] Upstream: simplified Content-Encoding handling.

Sergey Kandaurov
May 30, 2022 06:34PM
details: https://hg.nginx.org/nginx/rev/e0027c8438b0
branches:
changeset: 8029:e0027c8438b0
user: Maxim Dounin <mdounin@mdounin.ru>
date: Mon May 30 21:25:42 2022 +0300
description:
Upstream: simplified Content-Encoding handling.

Since introduction of offset handling in ngx_http_upstream_copy_header_line()
in revision 573:58475592100c, the ngx_http_upstream_copy_content_encoding()
function is no longer needed, as its behaviour is exactly equivalent to
ngx_http_upstream_copy_header_line() with appropriate offset. As such,
the ngx_http_upstream_copy_content_encoding() function was removed.

Further, the u->headers_in.content_encoding field is not used anywhere,
so it was removed as well.

Further, Content-Encoding handling no longer depends on NGX_HTTP_GZIP,
as it can be used even without any gzip handling compiled in (for example,
in the charset filter).

diffstat:

src/http/ngx_http_upstream.c | 36 +++---------------------------------
src/http/ngx_http_upstream.h | 4 ----
2 files changed, 3 insertions(+), 37 deletions(-)

diffs (75 lines):

diff -r 27d12017f300 -r e0027c8438b0 src/http/ngx_http_upstream.c
--- a/src/http/ngx_http_upstream.c Mon May 30 21:25:40 2022 +0300
+++ b/src/http/ngx_http_upstream.c Mon May 30 21:25:42 2022 +0300
@@ -147,11 +147,6 @@ static ngx_int_t ngx_http_upstream_rewri
static ngx_int_t ngx_http_upstream_copy_allow_ranges(ngx_http_request_t *r,
ngx_table_elt_t *h, ngx_uint_t offset);

-#if (NGX_HTTP_GZIP)
-static ngx_int_t ngx_http_upstream_copy_content_encoding(ngx_http_request_t *r,
- ngx_table_elt_t *h, ngx_uint_t offset);
-#endif
-
static ngx_int_t ngx_http_upstream_add_variables(ngx_conf_t *cf);
static ngx_int_t ngx_http_upstream_addr_variable(ngx_http_request_t *r,
ngx_http_variable_value_t *v, uintptr_t data);
@@ -316,12 +311,10 @@ static ngx_http_upstream_header_t ngx_h
ngx_http_upstream_process_transfer_encoding, 0,
ngx_http_upstream_ignore_header_line, 0, 0 },

-#if (NGX_HTTP_GZIP)
{ ngx_string("Content-Encoding"),
- ngx_http_upstream_process_header_line,
- offsetof(ngx_http_upstream_headers_in_t, content_encoding),
- ngx_http_upstream_copy_content_encoding, 0, 0 },
-#endif
+ ngx_http_upstream_ignore_header_line, 0,
+ ngx_http_upstream_copy_header_line,
+ offsetof(ngx_http_headers_out_t, content_encoding), 0 },

{ ngx_null_string, NULL, 0, NULL, 0, 0 }
};
@@ -5349,29 +5342,6 @@ ngx_http_upstream_copy_allow_ranges(ngx_
}


-#if (NGX_HTTP_GZIP)
-
-static ngx_int_t
-ngx_http_upstream_copy_content_encoding(ngx_http_request_t *r,
- ngx_table_elt_t *h, ngx_uint_t offset)
-{
- ngx_table_elt_t *ho;
-
- ho = ngx_list_push(&r->headers_out.headers);
- if (ho == NULL) {
- return NGX_ERROR;
- }
-
- *ho = *h;
-
- r->headers_out.content_encoding = ho;
-
- return NGX_OK;
-}
-
-#endif
-
-
static ngx_int_t
ngx_http_upstream_add_variables(ngx_conf_t *cf)
{
diff -r 27d12017f300 -r e0027c8438b0 src/http/ngx_http_upstream.h
--- a/src/http/ngx_http_upstream.h Mon May 30 21:25:40 2022 +0300
+++ b/src/http/ngx_http_upstream.h Mon May 30 21:25:42 2022 +0300
@@ -285,10 +285,6 @@ typedef struct {
ngx_table_elt_t *transfer_encoding;
ngx_table_elt_t *vary;

-#if (NGX_HTTP_GZIP)
- ngx_table_elt_t *content_encoding;
-#endif
-
ngx_table_elt_t *cache_control;
ngx_table_elt_t *set_cookie;

_______________________________________________
nginx-devel mailing list -- nginx-devel@nginx.org
To unsubscribe send an email to nginx-devel-leave@nginx.org
Subject Author Views Posted

[nginx] Upstream: simplified Content-Encoding handling.

Sergey Kandaurov 172 May 30, 2022 06:34PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 54
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready