Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Do not break downstream connection on proxy_cache write error

Maxim Dounin
May 09, 2022 11:18AM
Hello!

On Mon, May 09, 2022 at 04:12:40PM +0300, Kipras wrote:

[...]

> P.S. if i could ask - what does the p->cacheable flag mean?

It basically means "save the whole to response to the temporary
file, it will be used for caching/store". Note well that as of
now, it is only set at the very start of the event pipe operation,
when initializing u->pipe in ngx_http_upstream_send_response(),
and it might not be safe to simply switch it off at some point.

> The
> ngx_event_pipe_t
> struct is not documented in
> http://nginx.org/en/docs/dev/development_guide.html
> and it is kinda hard to understand all the pipes/buffers and the buffer
> shadowing mechanism/purpose just from reading the code :)

The code is basically the only documentation available about the
code (history and commit logs might be also helpful). The
development guide is mostly about explaining some basic things,
and it is focused on how to write modules, not on explaining how
existing modules work. If you want to change the existing code,
you'll have to read the code carefully to understand what the code
does.

--
Maxim Dounin
http://mdounin.ru/
_______________________________________________
nginx-devel mailing list -- nginx-devel@nginx.org
To unsubscribe send an email to nginx-devel-leave@nginx.org
Subject Author Views Posted

[PATCH] Do not break downstream connection on proxy_cache write error

kipras 227 May 02, 2022 09:38AM

Re: [PATCH] Do not break downstream connection on proxy_cache write error

Maxim Dounin 61 May 02, 2022 05:04PM

Re: [PATCH] Do not break downstream connection on proxy_cache write error

kipras 20 May 09, 2022 09:16AM

Re: [PATCH] Do not break downstream connection on proxy_cache write error

Maxim Dounin 20 May 09, 2022 11:18AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 83
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready