Welcome! Log In Create A New Profile

Advanced

[PATCH 08 of 10] Tests: tests for duplicate response headers

Maxim Dounin
April 20, 2022 07:32PM
# HG changeset patch
# User Maxim Dounin <mdounin@mdounin.ru>
# Date 1650492938 -10800
# Thu Apr 21 01:15:38 2022 +0300
# Node ID c5a73a2d1e3702a194ac7e7d8494acbeaf7cefe7
# Parent 97a72607140290452a991ce98f3eb1d004b6eabc
Tests: tests for duplicate response headers.

diff --git a/proxy_duplicate_headers.t b/proxy_duplicate_headers.t
new file mode 100644
--- /dev/null
+++ b/proxy_duplicate_headers.t
@@ -0,0 +1,175 @@
+#!/usr/bin/perl
+
+# (C) Maxim Dounin
+
+# Test for http backend returning response with invalid and duplicate
+# headers.
+
+###############################################################################
+
+use warnings;
+use strict;
+
+use Test::More;
+use Socket qw/ CRLF /;
+
+BEGIN { use FindBin; chdir($FindBin::Bin); }
+
+use lib 'lib';
+use Test::Nginx;
+
+###############################################################################
+
+select STDERR; $| = 1;
+select STDOUT; $| = 1;
+
+my $t = Test::Nginx->new()->has(qw/http proxy/)->plan(8);
+
+$t->write_file_expand('nginx.conf', <<'EOF');
+
+%%TEST_GLOBALS%%
+
+daemon off;
+
+events {
+}
+
+http {
+ %%TEST_GLOBALS_HTTP%%
+
+ server {
+ listen 127.0.0.1:8080;
+ server_name localhost;
+
+ location / {
+ proxy_pass http://127.0.0.1:8081;
+ proxy_read_timeout 1s;
+ }
+ }
+}
+
+EOF
+
+$t->run_daemon(\&http_daemon);
+$t->run()->waitforsocket('127.0.0.1:' . port(8081));
+
+###############################################################################
+
+like(http_get('/'), qr/200 OK/, 'normal');
+
+TODO: {
+local $TODO = 'not yet';
+
+like(http_get('/invalid-length'), qr/502 Bad/, 'invalid length');
+like(http_get('/duplicate-length'), qr/502 Bad/, 'duplicate length');
+like(http_get('/unknown-transfer-encoding'), qr/502 Bad/,
+ 'unknown transfer encoding');
+like(http_get('/duplicate-transfer-encoding'), qr/502 Bad/,
+ 'duplicate transfer encoding');
+like(http_get('/length-and-transfer-encoding'), qr/502 Bad/,
+ 'length and transfer encoding');
+like(http_get('/transfer-encoding-and-length'), qr/502 Bad/,
+ 'transfer encoding and length');
+
+like(http_get('/duplicate-expires'), qr/Expires: foo(?!.*bar)/s,
+ 'duplicate expires ignored');
+
+}
+
+###############################################################################
+
+sub http_daemon {
+ my $server = IO::Socket::INET->new(
+ Proto => 'tcp',
+ LocalAddr => '127.0.0.1:' . port(8081),
+ Listen => 5,
+ Reuse => 1
+ )
+ or die "Can't create listening socket: $!\n";
+
+ local $SIG{PIPE} = 'IGNORE';
+
+ while (my $client = $server->accept()) {
+ $client->autoflush(1);
+
+ my $headers = '';
+ my $uri = '';
+
+ while (<$client>) {
+ $headers .= $_;
+ last if (/^\x0d?\x0a?$/);
+ }
+
+ $uri = $1 if $headers =~ /^\S+\s+([^ ]+)\s+HTTP/i;
+
+ if ($uri eq '/') {
+
+ print $client
+ 'HTTP/1.1 200 OK' . CRLF .
+ 'Connection: close' . CRLF .
+ 'Content-Length: 0' . CRLF . CRLF;
+
+ } elsif ($uri eq '/invalid-length') {
+
+ print $client
+ 'HTTP/1.1 200 OK' . CRLF .
+ 'Connection: close' . CRLF .
+ 'Content-Length: foo' . CRLF . CRLF;
+
+ } elsif ($uri eq '/duplicate-length') {
+
+ print $client
+ 'HTTP/1.1 200 OK' . CRLF .
+ 'Connection: close' . CRLF .
+ 'Content-Length: 0' . CRLF .
+ 'Content-Length: 0' . CRLF . CRLF;
+
+ } elsif ($uri eq '/unknown-transfer-encoding') {
+
+ print $client
+ 'HTTP/1.1 200 OK' . CRLF .
+ 'Connection: close' . CRLF .
+ 'Transfer-Encoding: foo' . CRLF . CRLF;
+
+ } elsif ($uri eq '/duplicate-transfer-encoding') {
+
+ print $client
+ 'HTTP/1.1 200 OK' . CRLF .
+ 'Connection: close' . CRLF .
+ 'Transfer-Encoding: chunked' . CRLF .
+ 'Transfer-Encoding: chunked' . CRLF . CRLF .
+ '0' . CRLF . CRLF;
+
+ } elsif ($uri eq '/length-and-transfer-encoding') {
+
+ print $client
+ 'HTTP/1.1 200 OK' . CRLF .
+ 'Connection: close' . CRLF .
+ 'Content-Length: 0' . CRLF .
+ 'Transfer-Encoding: chunked' . CRLF . CRLF .
+ '0' . CRLF . CRLF;
+
+ } elsif ($uri eq '/transfer-encoding-and-length') {
+
+ print $client
+ 'HTTP/1.1 200 OK' . CRLF .
+ 'Connection: close' . CRLF .
+ 'Transfer-Encoding: chunked' . CRLF .
+ 'Content-Length: 0' . CRLF . CRLF .
+ '0' . CRLF . CRLF;
+
+ } elsif ($uri eq '/duplicate-expires') {
+
+ print $client
+ 'HTTP/1.1 200 OK' . CRLF .
+ 'Connection: close' . CRLF .
+ 'Expires: foo' . CRLF .
+ 'Expires: bar' . CRLF . CRLF;
+
+ }
+
+ close $client;
+ }
+}
+
+###############################################################################

_______________________________________________
nginx-devel mailing list -- nginx-devel@nginx.org
To unsubscribe send an email to nginx-devel-leave@nginx.org
Subject Author Views Posted

[PATCH 00 of 20] multiple headers handling

Maxim Dounin 959 April 20, 2022 06:38PM

[PATCH 03 of 20] SCGI: combining headers with identical names (ticket #1724)

Maxim Dounin 241 April 20, 2022 06:40PM

[PATCH 02 of 20] FastCGI: combining headers with identical names (ticket #1724)

Maxim Dounin 192 April 20, 2022 06:42PM

Re: [PATCH 02 of 20] FastCGI: combining headers with identical names (ticket #1724)

Sergey Kandaurov 240 May 11, 2022 11:36AM

Re: [PATCH 02 of 20] FastCGI: combining headers with identical names (ticket #1724)

Maxim Dounin 158 May 12, 2022 06:34PM

Re: [PATCH 02 of 20] FastCGI: combining headers with identical names (ticket #1724)

Sergey Kandaurov 254 May 13, 2022 10:06AM

Re: [PATCH 02 of 20] FastCGI: combining headers with identical names (ticket #1724)

Sergey Kandaurov 158 May 13, 2022 10:06AM

[PATCH 04 of 20] Uwsgi: combining headers with identical names (ticket #1724)

Maxim Dounin 209 April 20, 2022 06:44PM

[PATCH 08 of 20] Perl: all known input headers are handled identically

Maxim Dounin 278 April 20, 2022 06:44PM

[PATCH 10 of 20] Upstream: style

Maxim Dounin 247 April 20, 2022 06:46PM

[PATCH 07 of 20] All non-unique input headers are now linked lists

Maxim Dounin 324 April 20, 2022 06:48PM

Re: [PATCH 07 of 20] All non-unique input headers are now linked lists

Sergey Kandaurov 311 May 11, 2022 03:44PM

Re: [PATCH 07 of 20] All non-unique input headers are now linked lists

Maxim Dounin 159 May 12, 2022 07:56PM

[PATCH 09 of 20] Perl: combining unknown headers during $r->header_in() lookup

Maxim Dounin 186 April 20, 2022 06:50PM

[PATCH 12 of 20] Upstream: simplified Accept-Ranges handling

Maxim Dounin 338 April 20, 2022 06:52PM

[PATCH 11 of 20] Upstream: simplified Content-Encoding handling

Maxim Dounin 239 April 20, 2022 06:54PM

Re: [PATCH 11 of 20] Upstream: simplified Content-Encoding handling

Sergey Kandaurov 200 May 11, 2022 04:02PM

Re: [PATCH 11 of 20] Upstream: simplified Content-Encoding handling

Maxim Dounin 186 May 12, 2022 08:20PM

[PATCH 05 of 20] Combining unknown headers during variables lookup (ticket #1316)

Maxim Dounin 171 April 20, 2022 06:56PM

Re: [PATCH 05 of 20] Combining unknown headers during variables lookup (ticket #1316)

Sergey Kandaurov 207 May 11, 2022 12:12PM

Re: [PATCH 05 of 20] Combining unknown headers during variables lookup (ticket #1316)

Maxim Dounin 271 May 12, 2022 07:18PM

[PATCH 06 of 20] Reworked multi headers to use linked lists

Maxim Dounin 259 April 20, 2022 06:58PM

Re: [PATCH 06 of 20] Reworked multi headers to use linked lists

Sergey Kandaurov 182 May 11, 2022 03:24PM

Re: [PATCH 06 of 20] Reworked multi headers to use linked lists

Maxim Dounin 204 May 12, 2022 07:44PM

Re: [PATCH 06 of 20] Reworked multi headers to use linked lists

Sergey Kandaurov 353 June 13, 2022 01:08PM

Re: [PATCH 06 of 20] Reworked multi headers to use linked lists

Maxim Dounin 191 June 13, 2022 06:52PM

[PATCH 14 of 20] Upstream: all known headers in u->headers_in are linked lists now

Maxim Dounin 233 April 20, 2022 07:00PM

[PATCH 13 of 20] All known output headers can be linked lists now

Maxim Dounin 173 April 20, 2022 07:02PM

[PATCH 15 of 20] Upstream: header handlers can now return parsing errors

Maxim Dounin 160 April 20, 2022 07:04PM

Re: [PATCH 15 of 20] Upstream: header handlers can now return parsing errors

Sergey Kandaurov 178 May 11, 2022 04:30PM

Re: [PATCH 15 of 20] Upstream: header handlers can now return parsing errors

Maxim Dounin 180 May 12, 2022 08:26PM

[PATCH 17 of 20] Upstream: handling of multiple Vary headers (ticket #1423)

Maxim Dounin 200 April 20, 2022 07:06PM

Re: [PATCH 17 of 20] Upstream: handling of multiple Vary headers (ticket #1423)

Sergey Kandaurov 189 May 11, 2022 04:48PM

Re: [PATCH 17 of 20] Upstream: handling of multiple Vary headers (ticket #1423)

Maxim Dounin 155 May 12, 2022 08:52PM

[PATCH 18 of 20] Upstream: multiple WWW-Authenticate headers (ticket #485)

Maxim Dounin 165 April 20, 2022 07:08PM

Re: [PATCH 18 of 20] Upstream: multiple WWW-Authenticate headers (ticket #485)

Sergey Kandaurov 195 May 11, 2022 05:06PM

Re: [PATCH 18 of 20] Upstream: multiple WWW-Authenticate headers (ticket #485)

Maxim Dounin 167 May 12, 2022 10:00PM

Re: [PATCH 18 of 20] Upstream: multiple WWW-Authenticate headers (ticket #485)

Sergey Kandaurov 180 May 20, 2022 09:56AM

Re: [PATCH 18 of 20] Upstream: multiple WWW-Authenticate headers (ticket #485)

Maxim Dounin 168 May 20, 2022 05:10PM

[PATCH 16 of 20] Upstream: duplicate headers ignored or properly linked

Maxim Dounin 223 April 20, 2022 07:10PM

Re: [PATCH 16 of 20] Upstream: duplicate headers ignored or properly linked

Sergey Kandaurov 165 May 11, 2022 04:36PM

Re: [PATCH 16 of 20] Upstream: duplicate headers ignored or properly linked

Maxim Dounin 545 May 12, 2022 08:36PM

[PATCH 20 of 20] Headers filter: improved memory allocation error handling

Maxim Dounin 209 April 20, 2022 07:12PM

[PATCH 19 of 20] Auth request: multiple WWW-Authenticate headers (ticket #485)

Maxim Dounin 216 April 20, 2022 07:14PM

[PATCH 00 of 10] multiple headers tests

Maxim Dounin 210 April 20, 2022 07:16PM

[PATCH 01 of 10] Tests: tests for passing Date and Server headers

Maxim Dounin 169 April 20, 2022 07:18PM

[PATCH 02 of 10] Tests: fastcgi tests for combining headers

Maxim Dounin 229 April 20, 2022 07:20PM

[PATCH 03 of 10] Tests: scgi tests for combining headers

Maxim Dounin 174 April 20, 2022 07:20PM

[PATCH 04 of 10] Tests: uwsgi tests for combining headers

Maxim Dounin 143 April 20, 2022 07:22PM

[PATCH 07 of 10] Tests: perl $r->header_in() combining headers test

Maxim Dounin 160 April 20, 2022 07:24PM

[PATCH 09 of 10] Tests: tests for multiple Vary headers (ticket #1423)

Maxim Dounin 162 April 20, 2022 07:26PM

[PATCH 06 of 10] Tests: perl $r->header_in("Connection") test

Maxim Dounin 164 April 20, 2022 07:28PM

[PATCH 05 of 10] Tests: tests for various http header variables

Maxim Dounin 215 April 20, 2022 07:30PM

[PATCH 08 of 10] Tests: tests for duplicate response headers

Maxim Dounin 177 April 20, 2022 07:32PM

[PATCH 10 of 10] Tests: tests for multiple WWW-Authenticate headers (ticket #485)

Maxim Dounin 191 April 20, 2022 07:34PM

Re: [PATCH 00 of 10] multiple headers tests

Sergey Kandaurov 216 May 31, 2022 07:14PM

Re: [PATCH 00 of 10] multiple headers tests

Maxim Dounin 150 June 03, 2022 07:26PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 117
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 500 on July 15, 2024
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready