Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

April 18, 2022 07:04PM
Hi, Vadim.

Thanks for your cooperation!

> @@ -5067,6 +5091,7 @@
> || (h->value.len == 1 && h->value.data[0] == '*'))
> {
> u->cacheable = 0;
> + u->cacheable_reason |= NGX_HTTP_CACHEABLE_VARY;
> }

> I don't see any reasons to store information about "Vary" header.

It should not cache only the Vary asterisk. it doesn't need to store this
information so we consider that your approach (bitmask) is correct.

> And we can call
> "ngx_http_upstream_cache_validate_regardless_order" only when cacheable
is still
> enabled after parsing all other headers.

Our approach is a bit different, u->cacheable should be determined after
completing all headers parsing. So we consider that it could be better not
to set here and there during parsing headers particularly in case of
u->cacheable reverts 1 to 0 if there is, it could be misread easily.

> I will prepare an improved version if you don't mind.

Sure! Can we pick your brain for this issue?

Thanks,
Yugo Horie


On Mon, Apr 18, 2022 at 19:19 Vadim Fedorenko <vadim.fedorenko@cdnnow.ru>
wrote:

> Hi Yugo!
>
> Looks like another solution with the same concept - store additional
> information
> about several headers. The second patch you proposed looks a bit
> overcomplicated
> inside this additional function. I don't see any reasons to store
> information
> about "Vary" header. AFAIU, weed special information about 3 headers:
> "Expires",
> "Cache-Control" and "X-Accel-Expires". And we can call
> "ngx_http_upstream_cache_validate_regardless_order" only when cacheable is
> still
> enabled after parsing all other headers. That approach will simplify the
> logic
> inside ngx_http_upstream_cache_validate_regardless_order. I will prepare an
> improved version if you don't mind.
>
> Thanks,
> Vadim
>
> On 18.04.2022 02:14, Yugo Horie wrote:
> > We're also interested in this issue because the CDN provider like us is
> > concerned about the problems with the headers that determine the cache
> freshness.
> > It is often a serious problem used in Nginx as the origin server or the
> > intermediate cache server that has such problems.
> > In those days, we also proposed a patch to resolve it.
> >
> https://mailman.nginx.org/archives/list/nginx-devel@nginx.org/thread/ZQVPGEXAAHVL23TBBNMXLP4KDGDJCVTW/
> > <
> https://mailman.nginx.org/archives/list/nginx-devel@nginx.org/thread/ZQVPGEXAAHVL23TBBNMXLP4KDGDJCVTW/
> >
> >
> > But it seems to have declined. We sincerely wish to resolve it and
> intend to do
> > anything.
> >
> > Thanks,
> > Yugo Horie
> >
> > 2022年4月18日(月) 4:51 Vadim Fedorenko via nginx-devel <
> nginx-devel@nginx.org
> > <mailto:nginx-devel@nginx.org>>:
> >
> > Hi Maxim!
> >
> > On 17.04.2022 02:55, Maxim Dounin wrote:
> > > Hello!
> > >
> > >
> > > [...]
> > >
> > > Thanks for the patch.
> > >
> > > I'm quite sceptical about attempts to fix this by introducing
> > > various flags and reverting cacheable status back to 1. This is
> > > not how it should be fixed.
> > >
> > Yeah, the solution might be a bit complicated, but I couldn't find
> > another way without breaking concept of independent header parsing.
> > Could you please suggest something if you think that current approach
> > is wrong? The ticket that this patch tries to fix is 6 years old and
> > still has discussions going on without any solution.
> >
> > Thanks,
> > Vadim
> > _______________________________________________
> > nginx-devel mailing list -- nginx-devel@nginx.org <mailto:
> nginx-devel@nginx.org>
> > To unsubscribe send an email to nginx-devel-leave@nginx.org
> > <mailto:nginx-devel-leave@nginx.org>
> >
>
_______________________________________________
nginx-devel mailing list -- nginx-devel@nginx.org
To unsubscribe send an email to nginx-devel-leave@nginx.org
Subject Author Views Posted

[PATCH] Upstream: prioritise Cache-Control over Expires

Vadim Fedorenko via nginx-devel 1103 April 14, 2022 07:04PM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Maxim Dounin 159 April 16, 2022 09:56PM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Vadim Fedorenko via nginx-devel 189 April 17, 2022 03:52PM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

yugo-horie 232 April 17, 2022 09:16PM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Vadim Fedorenko via nginx-devel 214 April 18, 2022 06:22AM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

yugo-horie 200 April 18, 2022 07:04PM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Maxim Dounin 276 April 19, 2022 11:02AM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Maxim Dounin 140 April 22, 2022 02:24PM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Vadim Fedorenko via nginx-devel 252 April 22, 2022 03:08PM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Maxim Dounin 163 April 24, 2022 12:56AM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Maxim Dounin 148 April 24, 2022 11:44AM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

yugo-horie 190 April 25, 2022 08:28AM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Vadim Fedorenko via nginx-devel 194 April 25, 2022 05:04PM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Vadim Fedorenko via nginx-devel 168 April 25, 2022 05:08PM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Sergey Kandaurov 142 June 06, 2022 09:44AM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Sergey Kandaurov 119 June 06, 2022 10:42AM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Maxim Dounin 138 June 06, 2022 05:10PM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Sergey Kandaurov 166 June 07, 2022 12:02PM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Maxim Dounin 176 June 07, 2022 09:00PM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Sergey Kandaurov 159 June 10, 2022 07:40AM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Maxim Dounin 133 June 11, 2022 06:54PM

Re: [PATCH] Upstream: prioritise Cache-Control over Expires

Sergey Kandaurov 168 June 13, 2022 07:42AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 363
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 500 on July 15, 2024
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready