Welcome! Log In Create A New Profile

Advanced

Re: Fwd: 1.17.5 regression

Maxim Dounin
December 18, 2019 12:26PM
Hello!

On Mon, Dec 16, 2019 at 03:02:37PM +0100, Gábor Boskovits wrote:

> On berlin.guix.gnu.org we observed a regression upon upgrading nginx
> to 1.17.5. The problem was, when pipelining request to a proxy using
> tls, we suddenly started to get 408 client timeouts, manifesting in
> dropped connections. Currently we worked around the issue by
> downgrading to 1.17.4. I have collected some information about the
> problem here:
> https://gitlab.com/g_bor/fix-nginx-tls
> It contains the logs from the good and the bad version, a full nginx
> config, some info about how nginx was built. I managed to bisect the
> problem down to changeset 9d2ad2fb4423, which introduced the problem.
> Any help in further debuggin this would be greatly appreciated.

Thanks for the report, it indeed looks like a bug introduced
in 9d2ad2fb4423.

The problem is that c->read->handler is overwritted when switching
to the next pipelined request, ngx_ssl_next_read_handler() is not
called, and c->read->ready remains not set. I'll take a look how
to fix it properly.

Note well that a simpler workaround might be to build nginx with
the --with-cc-opt="-DNGX_HAVE_FIONREAD=0" configure argument, this
will disable the code in question on systems not using kqueue.

--
Maxim Dounin
http://mdounin.ru/
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

Fwd: 1.17.5 regression

Gábor Boskovits 130 December 16, 2019 09:04AM

Re: Fwd: 1.17.5 regression

Maxim Dounin 24 December 18, 2019 12:26PM

Re: Fwd: 1.17.5 regression

Gábor Boskovits 25 December 18, 2019 12:36PM

Re: Fwd: 1.17.5 regression

ru@nginx.com 23 December 19, 2019 03:46AM

Re: Fwd: 1.17.5 regression

Gábor Boskovits 21 December 19, 2019 04:34AM

Re: Fwd: 1.17.5 regression

Maxim Dounin 22 December 19, 2019 07:46AM

Re: Fwd: 1.17.5 regression

Gábor Boskovits 26 December 19, 2019 09:02AM

Re: Fwd: 1.17.5 regression

Maksim Yevmenkin 28 December 19, 2019 12:02PM

Re: Fwd: 1.17.5 regression

Maxim Dounin 21 December 23, 2019 08:36AM

Re: Fwd: 1.17.5 regression

Maxim Dounin 25 December 23, 2019 02:30PM

Re: Fwd: 1.17.5 regression

Gábor Boskovits 21 December 24, 2019 10:46AM

Re: Fwd: 1.17.5 regression

Maxim Dounin 24 December 24, 2019 11:46AM

Re: Fwd: 1.17.5 regression

Gábor Boskovits 20 December 24, 2019 11:56AM

Re: Fwd: 1.17.5 regression

Maksim Yevmenkin 22 December 24, 2019 12:02PM

Re: Fwd: 1.17.5 regression

Maxim Dounin 26 December 24, 2019 12:28PM

Re: 1.17.5 regression

Sergey Kandaurov 46 December 25, 2019 05:16AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 67
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready