Welcome! Log In Create A New Profile

Advanced

fix bug of fmt overflow

wy7980
November 10, 2018 07:18AM
# HG changeset patch
# User wy7980 <wy7980@gmail.com>
# Date 1541824641 -28800
# Sat Nov 10 12:37:21 2018 +0800
# Node ID e93ac0fd29c1f49e7dd49ff5e1efd58c009d359a
# Parent a2506436986ae9cf941fd9477aa77e28f501e11d

fix bug of fmt overflow

diff -r a2506436986a -r e93ac0fd29c1 src/core/ngx_string.c
--- a/src/core/ngx_string.c Tue Nov 06 16:32:09 2018 +0300
+++ b/src/core/ngx_string.c Sat Nov 10 12:37:21 2018 +0800
@@ -172,8 +172,9 @@
ngx_uint_t width, sign, hex, max_width, frac_width, scale,
n;
ngx_str_t *v;
ngx_variable_value_t *vv;
-
- while (*fmt && buf < last) {
+ char *fmt_last = (char *)fmt + strlen(fmt);
+
+ while (*fmt && buf < last && fmt < fmt_last) {

/*
* "buf < last" means that we could copy at least one character:
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

fix bug of fmt overflow

wy7980 244 November 10, 2018 07:18AM

Re: fix bug of fmt overflow

Valentin V. Bartenev 98 November 10, 2018 07:30AM

Re: fix bug of fmt overflow

wy7980 92 November 10, 2018 08:20AM

Re: fix bug of fmt overflow

Valentin V. Bartenev 121 November 10, 2018 10:10AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 238
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready