Welcome! Log In Create A New Profile

Advanced

patch for #1416 xslt_stylesheet parameter only works on first request

Karim Malhas
November 15, 2017 03:58PM
Hi all,

I recently discovered a bug [0] concerning the xslt_stylesheet directive as
documented here [1].

The root cause of this issue is that the parser of the directive also
modifies it instead of just reading it.

I have created a patch which lets the parser work on a copy of that
data, so that changes to it will not affect subsequent requests.

In my opinion this is merely a workaround, the parser probably should
not modify the data it parsed from the configuration file, but I didn't
feel comfortable to make such a big change.

Since this is my first time working with nginx I am seeking feedback on
the approach I used.


Kind regards,
Karim Malhas



[0] https://trac.nginx.org/nginx/ticket/1416
[1] https://nginx.org/en/docs/http/ngx_http_xslt_module.html#xslt_stylesheet

--

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

patch for #1416 xslt_stylesheet parameter only works on first request

Karim Malhas 709 November 15, 2017 03:58PM

Re: patch for #1416 xslt_stylesheet parameter only works on first request

ru@nginx.com 427 November 16, 2017 05:16AM

Re: patch for #1416 xslt_stylesheet parameter only works on first request

Karim Malhas 315 November 16, 2017 06:16AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 118
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready