Welcome! Log In Create A New Profile

Advanced

Re: Add support for buffering is scripted logs

Alexey Ivanov
August 14, 2017 02:26PM
using syslog for that particular usecase seem way more elegant, customizable, and simple. As a side bonus you won't block event loop on vfs operations (open/write/close).

> On Aug 14, 2017, at 11:00 AM, Eran Kornblau <eran.kornblau@kaltura.com> wrote:
>
>>
>> -----Original Message-----
>> From: nginx-devel [mailto:nginx-devel-bounces@nginx.org] On Behalf Of Maxim Dounin
>> Sent: Monday, August 14, 2017 8:34 PM
>> To: nginx-devel@nginx.org
>> Subject: Re: Add support for buffering is scripted logs
>>
>>> Ok, so is that a final 'no' for this whole feature, or is there is anything else I can do to get this feature in?
>>
>> It is certainly not a "final no". As I wrote in the very first comment, a) it's just a quick note, nothing more, and b) the feature is questionable. If a good implementation will be submitted, we can consider committing it.
>>
> That's good, I thought you were just rejecting politely :)
>
> It would be really great if you could point me to specific parts you think look bad.
> For example, I'm guessing that you don't like the callbacks I added to open file cache,
> but I was thinking that it's better to do it this way than to duplicate large chunks of code
> and write an open file cache specific to log, please let me know if you think otherwise.
> Any feedback you can provide will be appreciated
>
> Thanks
>
> Eran
>
>> --
>> Maxim Dounin
>> http://nginx.org/
>> _______________________________________________
> _______________________________________________
> nginx-devel mailing list
> nginx-devel@nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

Add support for buffering is scripted logs Attachments

erankor 789 August 07, 2017 06:38AM

Re: Add support for buffering is scripted logs

Maxim Dounin 413 August 14, 2017 11:46AM

RE: Add support for buffering is scripted logs

erankor 618 August 14, 2017 12:02PM

Re: Add support for buffering is scripted logs

Maxim Dounin 395 August 14, 2017 12:56PM

RE: Add support for buffering is scripted logs

erankor 583 August 14, 2017 01:12PM

Re: Add support for buffering is scripted logs

Maxim Dounin 404 August 14, 2017 01:36PM

RE: Add support for buffering is scripted logs

erankor 595 August 14, 2017 02:02PM

Re: Add support for buffering is scripted logs

Alexey Ivanov 393 August 14, 2017 02:26PM

RE: Add support for buffering is scripted logs

erankor 576 August 14, 2017 05:26PM

Re: Add support for buffering is scripted logs

Alexey Ivanov 448 August 14, 2017 06:44PM

Re: Add support for buffering is scripted logs

Maxim Dounin 414 August 14, 2017 03:02PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 313
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready