Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] auto/lib/conf: fix PCRE condition WRT the http and http_rewrite options

July 15, 2017 06:38AM
On Fri, Jul 14, 2017 at 01:25:13PM +0300, Maxim Dounin wrote:
> On Fri, Jul 14, 2017 at 12:08:45PM +0200, Samuel Martin wrote:
>
> > http_rewrite module cannot be selected when http server is disabled, so
> > fix the PCRE check condition to avoid irrelevant check failure.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/bc7/bc7458b97a88785653845afd30fe9d5f3a69905b/build-end.log
> >
> > Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> > ---
> > auto/lib/conf | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/auto/lib/conf b/auto/lib/conf
> > index 0b8545a3..2c7af104 100644
> > --- a/auto/lib/conf
> > +++ b/auto/lib/conf
> > @@ -7,7 +7,7 @@ if [ $USE_PCRE = YES -o $PCRE != NONE ]; then
> > . auto/lib/pcre/conf
> >
> > else
> > - if [ $USE_PCRE = DISABLED -a $HTTP_REWRITE = YES ]; then
> > + if [ $USE_PCRE = DISABLED -a $HTTP = YES -a $HTTP_REWRITE = YES ]; then
> >
> > cat << END
> >
>
> Seems to be a regression from 4d874b4d82ed (1.11.11),
> http://hg.nginx.org/nginx/rev/4d874b4d82ed.
>
> Ruslan, please take a look.

Suggest to commit the following:

# HG changeset patch
# User Ruslan Ermilov <ru@nginx.com>
# Date 1500114987 -10800
# Sat Jul 15 13:36:27 2017 +0300
# Node ID 207fda85a217a950875540633c4adb72a2f24dfe
# Parent a27e0c7e198ce989a181fba3c22d0c17e18f84a0
Configure: fixed PCRE requirement check by ngx_http_rewrite_module.

The http_rewrite module cannot be selected when http is disabled.
Fixed the PCRE check condition to avoid irrelevant check failure.
This is a regression from 4d874b4d82ed.

Signed-off-by: Samuel Martin <s.martin49@gmail.com>

diff --git a/auto/lib/conf b/auto/lib/conf
--- a/auto/lib/conf
+++ b/auto/lib/conf
@@ -7,7 +7,7 @@ if [ $USE_PCRE = YES -o $PCRE != NONE ];
. auto/lib/pcre/conf

else
- if [ $USE_PCRE = DISABLED -a $HTTP_REWRITE = YES ]; then
+ if [ $USE_PCRE = DISABLED -a $HTTP = YES -a $HTTP_REWRITE = YES ]; then

cat << END

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] auto/lib/conf: fix PCRE condition WRT the http and http_rewrite options

Samuel Martin 512 July 14, 2017 06:10AM

Re: [PATCH] auto/lib/conf: fix PCRE condition WRT the http and http_rewrite options

Maxim Dounin 283 July 14, 2017 06:26AM

Re: [PATCH] auto/lib/conf: fix PCRE condition WRT the http and http_rewrite options

ru@nginx.com 416 July 15, 2017 06:38AM

Re: [PATCH] auto/lib/conf: fix PCRE condition WRT the http and http_rewrite options

ru@nginx.com 487 July 19, 2017 05:12AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 307
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready