Valentin V. Bartenev
July 24, 2017 07:28PM
On Monday 24 July 2017 12:33:55 Vlad Krasnov via nginx-devel wrote:
[..]
> >> + ngx_http_v2_hpack_enc_entry_t htable[HPACK_ENC_HTABLE_SZ];
> >> + ngx_http_v2_hpack_name_entry_t heads[HPACK_ENC_DYNAMIC_KEY_TBL_SZ];
> >> + u_char storage[NGX_HTTP_V2_MAX_HPACK_TABLE_SIZE +
> >> + HPACK_ENC_MAX_ENTRY];
> >> +} ngx_http_v2_hpack_enc_t;
> >> +#endif
> >> +
> >> +
> >
> > Well, it means that even idle connection will consume 18+ KB more
> > memory than before.
> >
> > That doesn't look like a generic solution suitable for most of our users.
> > It should be at least configurable.
> >
>
> I can make it configurable fairly easily, but then it will require an extra allocation.
>

With your current patch ngx_http_v2_connection_s doesn't fit into
memory pool anymore and requires an extra allocation anyway.

wbr, Valentin V. Bartenev

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] HTTP/2: add support for HPACK encoding

Vlad Krasnov via nginx-devel 930 June 22, 2017 09:24PM

Re: [PATCH] HTTP/2: add support for HPACK encoding

Valentin V. Bartenev 554 June 23, 2017 09:36AM

Re: [PATCH] HTTP/2: add support for HPACK encoding

Valentin V. Bartenev 341 July 24, 2017 02:44PM

Re: [PATCH] HTTP/2: add support for HPACK encoding

Vlad Krasnov via nginx-devel 323 July 24, 2017 03:34PM

Re: [PATCH] HTTP/2: add support for HPACK encoding

Valentin V. Bartenev 343 July 24, 2017 07:28PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 78
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready