Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Output chain: propagate flush and last_buf flags to send_chain()

Piotr Sikora via nginx-devel
June 17, 2017 05:00PM
Hey Maxim,

> Note well that in HTTP/2-related code the special flag
> c->need_last_buf is used to indicate that a (fake) connection
> needs an information about last_buf, thus allowing HTTP/2
> c->send_chain() wrapper to add its own framing. If the goal is
> the same, please consider using the same approach.

Yes, it's exactly the same use case.

I originally used c->need_last_buf, but then decided against it, since
c->send_chain() is "pluggable" and therefore we shouldn't be assuming
it's behavior, but I don't mind either way, as both solutions for work
my use case.

Best regards,
Piotr Sikora
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Output chain: propagate flush and last_buf flags to send_chain()

Piotr Sikora via nginx-devel 516 June 03, 2017 11:30PM

Re: [PATCH] Output chain: propagate flush and last_buf flags to send_chain()

Maxim Dounin 173 June 08, 2017 12:30PM

Re: [PATCH] Output chain: propagate flush and last_buf flags to send_chain()

Piotr Sikora via nginx-devel 177 June 17, 2017 05:00PM

[PATCH] Output chain: propagate last_buf flag to c->send_chain()

Piotr Sikora via nginx-devel 148 June 17, 2017 05:00PM

Re: [PATCH] Output chain: propagate last_buf flag to c->send_chain()

Maxim Dounin 229 June 20, 2017 11:58AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 222
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready