Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] HTTP/2: emit PROTOCOL_ERROR on invalid WINDOW_UPDATE increments

Piotr Sikora via nginx-devel
March 28, 2017 06:38AM
Hey Valentin,

> I'm not sure that strictly following RFC here is worth the effort.
>
> It seems there's no other "harm" from zero window updates except that it
> allows to reset timers without any progress. That's only slightly worse
> than 1-bytes window updates.

Flow control interoperability and deadlocks between various HTTP/2
implementations are the biggest issues with the protocol, so while
there is no real harm in allowing 0 window updates, they indicate
broken client, and resetting stream and/or connection as soon as such
thing happens makes it much easier to find issues.

> The downside is additional code and intolerance to potential client bugs.

Catching client bugs early on is the upside, IMHO.

> Also note that in your implementation if zero window update is received
> for unknown stream then it's silently ignored.

Good catch, thanks! I'll send fixed version shortly.

Best regards,
Piotr Sikora
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] HTTP/2: emit PROTOCOL_ERROR on invalid WINDOW_UPDATE increments

Piotr Sikora via nginx-devel 512 March 26, 2017 04:44AM

Re: [PATCH] HTTP/2: emit PROTOCOL_ERROR on invalid WINDOW_UPDATE increments

Valentin V. Bartenev 213 March 27, 2017 03:38PM

Re: [PATCH] HTTP/2: emit PROTOCOL_ERROR on invalid WINDOW_UPDATE increments

Piotr Sikora via nginx-devel 246 March 28, 2017 06:38AM

[PATCH] HTTP/2: emit PROTOCOL_ERROR on invalid WINDOW_UPDATE increments

Piotr Sikora via nginx-devel 239 March 28, 2017 06:54AM

Re: [PATCH] HTTP/2: emit PROTOCOL_ERROR on invalid WINDOW_UPDATE increments

Valentin V. Bartenev 298 March 28, 2017 01:26PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 79
Record Number of Users: 6 on February 13, 2018
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready