Welcome! Log In Create A New Profile

Advanced

RE: Add missing static specifiers

March 02, 2017 08:54AM
>
> -----Original Message-----
> From: nginx-devel [mailto:nginx-devel-bounces@nginx.org] On Behalf Of Maxim Dounin
> Sent: Thursday, March 2, 2017 3:37 PM
> To: nginx-devel@nginx.org
> Subject: Re: Add missing static specifiers
>
> Hello!
>
> On Thu, Mar 02, 2017 at 07:15:25AM +0000, Eran Kornblau wrote:
>
> [...]
>
> > >
> > Fixed, separated the ints and pointers into two blocks (that made more
> > sense to me than aligning them on a single block)
>
> Doesn't looks like a good solution to me. Rather, I would indent pointer names to the appropriate position, much like it is already done slightly above in the same file:
>
> static ngx_atomic_t connection_counter = 1;
> ngx_atomic_t *ngx_connection_counter = &connection_counter;
>
Fixed

> --
> Maxim Dounin
> http://nginx.org/
> _______________________________________________
> nginx-devel mailing list
> nginx-devel@nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel
>

Eran
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

Add missing static specifiers Attachments

erankor 824 February 28, 2017 02:22PM

Re: Add missing static specifiers

Maxim Dounin 424 February 28, 2017 03:24PM

RE: Add missing static specifiers Attachments

erankor 636 February 28, 2017 04:22PM

Re: Add missing static specifiers

Maxim Dounin 412 March 01, 2017 07:40PM

RE: Add missing static specifiers Attachments

erankor 575 March 02, 2017 02:16AM

Re: Add missing static specifiers

Maxim Dounin 435 March 02, 2017 08:38AM

RE: Add missing static specifiers Attachments

erankor 581 March 02, 2017 08:54AM

Re: Add missing static specifiers

Maxim Dounin 394 March 02, 2017 10:52AM

RE: Add missing static specifiers

erankor 628 March 02, 2017 04:34PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 160
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready