Hello!

On Tue, Nov 29, 2016 at 01:13:27PM +0200, Orgad Shaneh wrote:

> # HG changeset patch
> # User Orgad Shaneh <orgads@gmail.com>
> # Date 1480405065 -7200
> # Tue Nov 29 09:37:45 2016 +0200
> # Node ID e036a4628d9cc8803579d7d41848d528488eca6d
> # Parent 52bd8cc17f34bbebcb4d2ce3651b40af7d572d55
> Fix MinGW64 compilation

Style, should use "Configure: ..." prefix and trailing dot, e.g.:

Configure: fix MinGW64 compilation.

It may also be more specific about what "MinGW64 compilation"
means, see below.

>
> diff -r 52bd8cc17f34 -r e036a4628d9c auto/configure
> --- a/auto/configure Mon Nov 28 19:19:21 2016 +0300
> +++ b/auto/configure Tue Nov 29 09:37:45 2016 +0200
> @@ -36,7 +36,7 @@
> NGX_PLATFORM="$NGX_SYSTEM:$NGX_RELEASE:$NGX_MACHINE";
>
> case "$NGX_SYSTEM" in
> - MINGW32_*)
> + MINGW32_*|MINGW64_*)

Style, should be spaces around "|".

> NGX_PLATFORM=win32
> ;;
> esac

AFAIK, MinGW-w64 project doesn't provide any compilation
environment by itself. We do support compiling with mingw-w64 gcc
under MSYS, similar to how it's documented for MSVC at [1], but it
only returns MINGW32_* in "uname -s".

Do you mean compiling under some different environment? MSYS2?

[1] http://nginx.org/en/docs/howto_build_on_win32.html

--
Maxim Dounin
http://nginx.org/
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel