Welcome! Log In Create A New Profile

Advanced

Re: [PATCH 3 of 3] Limit req: change default response code when rate-limiting

Maxim Dounin
March 01, 2017 10:40AM
Hello!

On Tue, Feb 28, 2017 at 03:40:01PM -0800, Piotr Sikora via nginx-devel wrote:

> # HG changeset patch
> # User Piotr Sikora <piotrsikora@google.com>
> # Date 1488324535 28800
> # Tue Feb 28 15:28:55 2017 -0800
> # Node ID c9d43c652ac776068e78f695dde00606eed184f8
> # Parent e21f12a958010e1f3e5cdc1640859e335e032ca5
> Limit req: change default response code when rate-limiting.
>
> Previously, "503 Service Unavailable" response code was used, but
> the new "429 Too Many Requests" response code is more appropriate.
>
> Signed-off-by: Piotr Sikora <piotrsikora@google.com>
>
> diff -r e21f12a95801 -r c9d43c652ac7 src/http/modules/ngx_http_limit_req_module.c
> --- a/src/http/modules/ngx_http_limit_req_module.c
> +++ b/src/http/modules/ngx_http_limit_req_module.c
> @@ -712,7 +712,7 @@ ngx_http_limit_req_merge_conf(ngx_conf_t
> NGX_LOG_INFO : conf->limit_log_level + 1;
>
> ngx_conf_merge_uint_value(conf->status_code, prev->status_code,
> - NGX_HTTP_SERVICE_UNAVAILABLE);
> + NGX_HTTP_TOO_MANY_REQUESTS);
>
> return NGX_CONF_OK;
> }

As I already wrote, I certainly disagree with this change.

--
Maxim Dounin
http://nginx.org/
_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH 1 of 2] HTTP: add support for "429 Too Many Requests" response (RFC6585)

Piotr Sikora 990 October 19, 2016 03:54AM

[PATCH 2 of 2] HTTP: change default response code when rate-limiting requests

Piotr Sikora 303 October 19, 2016 03:54AM

Re: [PATCH 1 of 2] HTTP: add support for "429 Too Many Requests" response (RFC6585)

Piotr Sikora via nginx-devel 287 November 29, 2016 08:10PM

Re: [PATCH 1 of 2] HTTP: add support for "429 Too Many Requests" response (RFC6585)

Piotr Sikora via nginx-devel 381 January 20, 2017 08:04PM

Re: [PATCH 1 of 2] HTTP: add support for "429 Too Many Requests" response (RFC6585)

Piotr Sikora via nginx-devel 231 February 22, 2017 10:40PM

Re: [PATCH 1 of 2] HTTP: add support for "429 Too Many Requests" response (RFC6585)

Maxim Dounin 237 February 25, 2017 06:46PM

[PATCH 1 of 3] HTTP: add support for "429 Too Many Requests" response (RFC6585)

Piotr Sikora via nginx-devel 586 February 28, 2017 06:42PM

[PATCH 2 of 3] Upstream: allow recovery from "429 Too Many Requests" response

Piotr Sikora via nginx-devel 287 February 28, 2017 06:42PM

Re: [PATCH 2 of 3] Upstream: allow recovery from "429 Too Many Requests" response

Maxim Dounin 231 March 01, 2017 10:34AM

Re: [PATCH 2 of 3] Upstream: allow recovery from "429 Too Many Requests" response

Piotr Sikora via nginx-devel 226 March 01, 2017 03:18PM

Re: [PATCH 2 of 3] Upstream: allow recovery from "429 Too Many Requests" response

Maxim Dounin 242 March 01, 2017 07:00PM

Re: [PATCH 2 of 3] Upstream: allow recovery from "429 Too Many Requests" response

Piotr Sikora via nginx-devel 239 March 24, 2017 06:50AM

[PATCH 3 of 3] Limit req: change default response code when rate-limiting

Piotr Sikora via nginx-devel 219 February 28, 2017 06:42PM

Re: [PATCH 3 of 3] Limit req: change default response code when rate-limiting

Maxim Dounin 226 March 01, 2017 10:40AM

Re: [PATCH 3 of 3] Limit req: change default response code when rate-limiting

Piotr Sikora via nginx-devel 217 March 01, 2017 03:22PM

Re: [PATCH 3 of 3] Limit req: change default response code when rate-limiting

Maxim Dounin 252 March 01, 2017 07:18PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 249
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready