Hello!

On Fri, Jul 01, 2016 at 05:05:18PM -0700, Piotr Sikora wrote:

> # HG changeset patch
> # User Piotr Sikora <piotrsikora@google.com>
> # Date 1467064815 25200
> # Mon Jun 27 15:00:15 2016 -0700
> # Node ID 7da099858a643bc63a26082604f01910df444ad6
> # Parent d452cb27639f714bc43b7f3ede417e3e7f8efdd6
> Configure: remove test based on Linux kernel version.
>
> Proper test for posix_fadvise() is done as part of auto/unix.
>
> Signed-off-by: Piotr Sikora <piotrsikora@google.com>
>
> diff -r d452cb27639f -r 7da099858a64 auto/os/linux
> --- a/auto/os/linux
> +++ b/auto/os/linux
> @@ -16,22 +16,6 @@ cc_aux_flags="$CC_AUX_FLAGS"
> CC_AUX_FLAGS="$cc_aux_flags -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64"
>
>
> -# Linux kernel version
> -
> -version=$((`uname -r \
> - | sed -n -e 's/^\([0-9][0-9]*\)\.\([0-9][0-9]*\)\.\([0-9][0-9]*\).*/ \
> - \1*256*256+\2*256+\3/p' \
> - -e 's/^\([0-9][0-9]*\)\.\([0-9][0-9]*\).*/\1*256*256+\2*256/p'`))
> -
> -version=${version:-0}
> -
> -
> -# posix_fadvise64() had been implemented in 2.5.60
> -
> -if [ $version -lt 132412 ]; then
> - have=NGX_HAVE_POSIX_FADVISE . auto/nohave
> -fi
> -
> # epoll, EPOLLET version
>
> ngx_feature="epoll"

The code in question disables posix_fadvise() on old kernels, as
the test in auto/unix can lead to false positive results.

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel