Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Core: reorder #ifdef in .h file to match order in .c file

Piotr Sikora
July 13, 2016 01:30PM
Hey Maxim,

> Current order matches one used in #if in the same .h file, and I
> don't think this order needs to be changed.

Hmm? Are we looking at the same files?

http://hg.nginx.org/nginx/file/tip/src/os/unix/ngx_setaffinity.h:

#if (NGX_HAVE_SCHED_SETAFFINITY)
...
#elif (NGX_HAVE_CPUSET_SETAFFINITY)
...
#endif

http://hg.nginx.org/nginx/file/tip/src/os/unix/ngx_setaffinity.c:

#if (NGX_HAVE_CPUSET_SETAFFINITY)
....
#elif (NGX_HAVE_SCHED_SETAFFINITY)
....
#endif

The order is different... And yes, I know that's nitpicking.

Best regards,
Piotr Sikora

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Core: reorder #ifdef in .h file to match order in .c file

Piotr Sikora 361 June 27, 2016 10:58PM

Re: [PATCH] Core: reorder #ifdef in .h file to match order in .c file

Maxim Dounin 194 July 08, 2016 10:14AM

Re: [PATCH] Core: reorder #ifdef in .h file to match order in .c file

Piotr Sikora 174 July 13, 2016 01:30PM

Re: [PATCH] Core: reorder #ifdef in .h file to match order in .c file

Maxim Dounin 183 July 13, 2016 02:02PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 172
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready