Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Headers filter: style

Maxim Dounin
June 23, 2016 03:12PM
Hello!

On Thu, Jun 23, 2016 at 09:53:37AM -0700, Piotr Sikora wrote:

> Hey Maxim,
>
> > I would rather not. The "hv" is used to refer to a particular
> > ngx_http_header_val_t, while "h" here is an array of elements.
>
> But "h" is used throughout the codebase for ngx_table_elt_t, which
> makes this particular case confusing.
>
> Also, "h" is used for ngx_table_elt_t regardless of whether it points
> to a particular item or an array, so your argument isn't consistent
> with the current style.

The "h" is used for variables of various types, including
ngx_http_file_cache_header_t, ngx_str_t, ngx_keyval_t,
ngx_table_elt_t, ngx_http_fastcgi_header_t, ngx_uint_t, uin32_t,
and int. It's just a convenient short name for a variable.

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Headers filter: style

Piotr Sikora 332 June 22, 2016 04:54PM

Re: [PATCH] Headers filter: style

Maxim Dounin 175 June 23, 2016 08:42AM

Re: [PATCH] Headers filter: style

Piotr Sikora 163 June 23, 2016 12:54PM

Re: [PATCH] Headers filter: style

Maxim Dounin 150 June 23, 2016 03:12PM

Re: [PATCH] Headers filter: style

Piotr Sikora 169 June 23, 2016 03:46PM

Re: [PATCH] Headers filter: style

洪志道 159 June 24, 2016 02:00AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 131
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready