Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Correct reference to GCC compiler macro

Maxim Dounin
April 01, 2016 06:46AM
Hello!

On Tue, Mar 01, 2016 at 01:40:13PM -0600, Joel Cunningham wrote:

> # HG changeset patch
> # User Joel Cunningham <joel.cunningham@me.com>
> # Date 1456860378 21600
> # Tue Mar 01 13:26:18 2016 -0600
> # Node ID cce5f2f6ed76ffa0f6890e90e7b1b68718ffa8a9
> # Parent 3b9fe734a76ca0863ec87596369690831e9f4086
> Correct reference to GCC compiler macro
>
> This commit corrects a small typo where __GNU__ was used in place of
> __GNUC__
>
> This was identified on a GCC system that built with undefined macros
> treated as errors when used with #if
>
> diff -r 3b9fe734a76c -r cce5f2f6ed76 src/core/ngx_config.h
> --- a/src/core/ngx_config.h Tue Mar 01 15:18:07 2016 +0300
> +++ b/src/core/ngx_config.h Tue Mar 01 13:26:18 2016 -0600
> @@ -125,7 +125,7 @@
> #endif
>
>
> -#if ((__GNU__ == 2) && (__GNUC_MINOR__ < 8))
> +#if ((__GNUC__ == 2) && (__GNUC_MINOR__ < 8))
> #define NGX_MAX_UINT32_VALUE (uint32_t) 0xffffffffLL
> #else
> #define NGX_MAX_UINT32_VALUE (uint32_t) 0xffffffff

I've tested with GCC 2.7 and commited a patch to remove this
preprocessor check:

http://hg.nginx.org/nginx/rev/5805301f990f

Thanks for reporting.

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Correct reference to GCC compiler macro

Joel Cunningham 741 March 01, 2016 02:42PM

Re: [PATCH] Correct reference to GCC compiler macro

Joel Cunningham 195 March 14, 2016 10:30AM

Re: [PATCH] Correct reference to GCC compiler macro

Maxim Dounin 268 March 14, 2016 10:48AM

Re: [PATCH] Correct reference to GCC compiler macro

Andrew Hutchings 336 March 16, 2016 01:16PM

Re: [PATCH] Correct reference to GCC compiler macro

Joel Cunningham 183 March 15, 2016 09:46AM

Re: [PATCH] Correct reference to GCC compiler macro

Maxim Dounin 226 April 01, 2016 06:46AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 239
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready