I will remove the tabs, not sure how they got there.

Regarding the minimal compression field: encoding 4 bytes yields real benefits. Values like “gzip” or “link” get one byte shoved off, which makes it 25% smaller and it adds up.
Less than 4 bytes is probably useless, but then again those are not common, and shouldn’t be a performance issue.

> On 17 Dec 2015, at 11:30, Valentin V. Bartenev <vbart@nginx.com> wrote:
>
> On Thursday 17 December 2015 01:36:07 Vlad Krasnov wrote:
>> # HG changeset patch
>> # User Vlad Krasnov <vlad@cloudflare.com>
>> # Date 1450274269 28800
>> # Wed Dec 16 05:57:49 2015 -0800
>> # Node ID d2e16044797ef7f7e0583e7c6dfdae5402c70d5c
>> # Parent def9c9c9ae05cfa7467b0ec96e76afa180c23dfb
>> HTTP/2: HPACK Huffman encoding
>>
>> Implement HPACK Huffman encoding for HTTP/2.
>> This reduces the size of headers by over 30% on average.
>>
> [..]
>
> Thank you for the patch. I'll look at it as time permits.
>
> From the brief glance I've spotted a number of style issues.
> The most obvious is mixed tabs and spaces in indentation.
>
> Also I think we shouldn't even try to compress values less
> than 4 bytes (or even more... like 8-16, IMO the probability
> of saving 1-4 bytes doesn't worth it).
>
> wbr, Valentin V. Bartenev
>
> _______________________________________________
> nginx-devel mailing list
> nginx-devel@nginx.org
> http://mailman.nginx.org/mailman/listinfo/nginx-devel

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel