Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] http_geo_module: warn when using a variable as the value

Maxim Dounin
December 17, 2015 09:16AM
Hello!

On Thu, Dec 17, 2015 at 01:47:50PM +0000, Daniel K. wrote:

> On 12/17/2015 12:44 PM, Maxim Dounin wrote:
> > On Wed, Dec 16, 2015 at 11:13:16PM +0000, Daniel K. wrote:
> >> Warn when using a variable as the data value in geo blocks
> >>
> >> Since the geo module does not expand variables, warn when a variable is
> >> used as the data value;
> >
> > As the geo module is currently probably the only way to insert
> > plain '$' into a place which expands variables, I'm not sure if
> > it's a good idea to add such a patch, at least before we'll
> > resolve the '$' escaping issue.
>
> It was just showing a warning to the possibly unsuspecting user, nothing
> else.
>
> Valentin suggested to add variable support. From your comment I take it
> that variable support is not wanted, at least not yet, until a machanism
> to escape '$' is implemented?

Yes, we'll have to introduce '$' escaping before (or at least
at the same time) adding variables support to geo.

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] http_geo_module: warn when using a variable as the value

Daniel K. 450 December 16, 2015 06:14PM

Re: [PATCH] http_geo_module: warn when using a variable as the value

Valentin V. Bartenev 209 December 17, 2015 06:08AM

Re: [PATCH] http_geo_module: warn when using a variable as the value

Daniel K. 218 December 17, 2015 08:44AM

Re: [PATCH] http_geo_module: warn when using a variable as the value

Maxim Dounin 238 December 17, 2015 07:46AM

Re: [PATCH] http_geo_module: warn when using a variable as the value

Daniel K. 190 December 17, 2015 08:48AM

Re: [PATCH] http_geo_module: warn when using a variable as the value

Maxim Dounin 208 December 17, 2015 09:16AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 93
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready