Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] HTTP: include SSI header only where it's needed

Piotr Sikora
October 26, 2015 05:48PM
Hey Maxim,

> I don't think this change is needed. Current approach is in line
> with what's done for other headers, and I see no serious enough
> reasons to change things.

Except that other headers (i.e. cache, ssl, v2) need to be included in
"core" http, because the functions they expose are used in "core"
http, whereas SSI is not. Basically, cache, ssl & v2 are all
compile-time options of the "core" http, whereas SSI is just an http
module and pulling SSI header in "core" http breaks layering &
separation of the modules.

This doesn't really matter if you compile nginx as a big monolith, but
if you want to go DSO route or build modules separately from "core"
http, then "core" http (i.e. ngx_http.h) shouldn't be pulling headers
from non-"core" http modules.

Best regards,
Piotr Sikora

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] HTTP: include SSI header only where it's needed

Piotr Sikora 471 October 24, 2015 07:28PM

Re: [PATCH] HTTP: include SSI header only where it's needed

Maxim Dounin 210 October 26, 2015 12:46PM

Re: [PATCH] HTTP: include SSI header only where it's needed

Piotr Sikora 211 October 26, 2015 05:48PM

Re: [PATCH] HTTP: include SSI header only where it's needed

Maxim Dounin 216 October 26, 2015 10:36PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 134
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready