Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Configure: remove redundant NGX_OPENSSL_MD5

Piotr Sikora
October 26, 2015 05:46PM
Hey Maxim,

> These macros are destinct. The NGX_HAVE_OPENSSL_MD5_H means that
> we are using "openssl/md5.h" include. Second one means that we
> are using OpenSSL-style function names, like "MD5_Init", and not
> RSA-like names like "MD5Init".
>
> Such a distinction may be needed when using external MD5 library
> with --with-md5.

Hmm... Are there any useful external MD5 libraries that use
OpenSSL-style function names?

>> diff -r 7435401242d6 -r 84b550025712 auto/lib/md5/conf
>> --- a/auto/lib/md5/conf
>> +++ b/auto/lib/md5/conf
>> @@ -8,8 +8,7 @@ if [ $MD5 != NONE ]; then
>> if grep MD5_Init $MD5/md5.h 2>&1 >/dev/null; then
>> # OpenSSL md5
>> OPENSSL_MD5=YES
>> - have=NGX_HAVE_OPENSSL_MD5 . auto/have
>> - have=NGX_OPENSSL_MD5 . auto/have
>> + have=NGX_HAVE_OPENSSL_MD5_H . auto/have
>
> I don't think this is a typo, rather it tries to define the
> NGX_HAVE_OPENSSL_MD5 macro, currently unused. Note that it tests
> "md5.h", not "openssl/md5.h".

Right... Shouldn't the unused macro be removed, then?

Best regards,
Piotr Sikora

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Configure: remove redundant NGX_OPENSSL_MD5

Piotr Sikora 544 October 24, 2015 07:28PM

Re: [PATCH] Configure: remove redundant NGX_OPENSSL_MD5

Maxim Dounin 207 October 26, 2015 08:52AM

Re: [PATCH] Configure: remove redundant NGX_OPENSSL_MD5

Piotr Sikora 220 October 26, 2015 05:46PM

Re: [PATCH] Configure: remove redundant NGX_OPENSSL_MD5

Maxim Dounin 249 October 26, 2015 10:10PM

Re: [PATCH] Configure: remove redundant NGX_OPENSSL_MD5

Piotr Sikora 255 November 06, 2015 08:50PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 163
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready