Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Support FreeBSD jails for testing

Maxim Dounin
October 19, 2015 09:54PM
Hello!

On Mon, Oct 19, 2015 at 11:39:27PM +0100, Steven Hartland wrote:

[...]

> >>That doesn't fix the directory permission issue which causes pretty much
> >>every test to fail, so is this still an option for inclusion?
> >Directory premissions may vary depending on umask used. If your
> >umask breaks tests for you - you may try changing it while running
> >tests. It also shouldn't be important when running tests under
> >non-privileged user.
> Confirmed it doesn't effect a non-privileged user.
>
> The default umask is 022 hence the issue if its run as privileged user with
> the default user as nobody which will have no access to the created
> directory.

Err, it looks like umask is unrelated here - it's File::Temp which
creates temp directory with 0700 access mode.

[...]

> Something to mention in the README, if you don't like the chmod?

For sure we don't want chmod(0777), as an world-writable temp
directory can easily result in problems when running tests on a
host with untrusted users. We can consider something like
chmod(0755), but I'm not sure it's a good idea either, and this
won't fix at least some tests.

As for the README, it already suggests to run under a
non-privileged user - it uses "$ " shell prompt in the usage
example. ;) If you think it's not enough and needs to be said
explicitly - patches are welcome.

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Support FreeBSD jails for testing

steveh 698 October 15, 2015 08:12PM

Re: [PATCH] Support FreeBSD jails for testing

Maxim Dounin 316 October 16, 2015 08:06AM

Re: [PATCH] Support FreeBSD jails for testing

steveh 403 October 16, 2015 01:26PM

Re: [PATCH] Support FreeBSD jails for testing

Maxim Dounin 281 October 19, 2015 01:58PM

Re: [PATCH] Support FreeBSD jails for testing

steveh 423 October 19, 2015 06:40PM

Re: [PATCH] Support FreeBSD jails for testing

Maxim Dounin 317 October 19, 2015 09:54PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 233
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready