Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Add configuration option for the timeout for childs handling SIGTERM.

Maxim Dounin
March 23, 2015 06:20PM
Hello!

On Mon, Mar 23, 2015 at 08:39:46PM +0100, Otto van der Schaaf wrote:

> Hi,
>
> For testing quick termination during high loads, while running with
> valgrind, it might be useful to be able to extend the amount of time nginx
> allows child processes to wrap up before sending SIGKILL.
> For ngx_pagespeed, the current hard-coded default of 1 second seems to be
> just short of what we need to be able to reliably test just this scenario,
> so I've made a patch so we can run with different values for with and
> without valgrind.
> Would the following patch be acceptable?

No. Note well that current limit isn't 1 second, you are
misunderstanding the code. It'll signal workers multiple times,
doubling wait time on each iteration, from 50ms to 1000ms
including.

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Add configuration option for the timeout for childs handling SIGTERM.

oschaaf 584 March 23, 2015 03:42PM

Re: [PATCH] Add configuration option for the timeout for childs handling SIGTERM.

Maxim Dounin 253 March 23, 2015 06:20PM

Re: [PATCH] Add configuration option for the timeout for childs handling SIGTERM.

oschaaf 292 March 23, 2015 06:36PM

Re: [PATCH] Add configuration option for the timeout for childs handling SIGTERM.

Maxim Dounin 262 March 24, 2015 01:04PM

Re: [PATCH] Add configuration option for the timeout for childs handling SIGTERM.

oschaaf 324 March 25, 2015 09:44AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 163
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready