Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Upstream: fixed $upstream_response_time for filter_finalize + error_page.

Yichun Zhang (agentzh)
March 02, 2015 02:40PM
Hi Maxim

On Mon, Mar 2, 2015 at 11:09 AM, Maxim Dounin wrote:
> I've committed this and another patch related to filter
> finalization, see here:
>
> http://hg.nginx.org/nginx/rev/5abf5af257a7
> http://hg.nginx.org/nginx/rev/5f179f344096
>

Great. Thanks!

> In the particular case you've described in the commit log of your
> patch, I would also recommend to avoid using filter finalization.
> When in header filter, it should be enough to just return
> appropriate code instead. Filter finalization is needed when
> working with a response body, not headers.
>

Oh I was not aware of that. Thanks for the suggestion and
clarification! I'll adjust my module code accordingly :)

Thanks!
-agentzh

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Upstream: fixed $upstream_response_time for filter_finalize + error_page.

Yichun Zhang (agentzh) 684 February 12, 2015 08:32PM

Re: [PATCH] Upstream: fixed $upstream_response_time for filter_finalize + error_page.

Maxim Dounin 352 February 13, 2015 10:06AM

Re: [PATCH] Upstream: fixed $upstream_response_time for filter_finalize + error_page.

Maxim Dounin 302 February 13, 2015 12:36PM

Re: [PATCH] Upstream: fixed $upstream_response_time for filter_finalize + error_page.

Yichun Zhang (agentzh) 296 February 15, 2015 05:06PM

Re: [PATCH] Upstream: fixed $upstream_response_time for filter_finalize + error_page.

Maxim Dounin 250 March 02, 2015 02:10PM

Re: [PATCH] Upstream: fixed $upstream_response_time for filter_finalize + error_page.

Yichun Zhang (agentzh) 279 March 02, 2015 02:40PM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 248
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready