Welcome! Log In Create A New Profile

Advanced

Re: [PATCH] Core: parse octal/hexadecimal numeric config directives

Maxim Dounin
November 10, 2014 10:24AM
Hello!

On Fri, Nov 07, 2014 at 01:19:43PM -0800, Ari Aosved wrote:

> # HG changeset patch
> # User Ari Aosved <ari.aosved@gmail.com>
> # Date 1415392382 28800
> # Fri Nov 07 12:33:02 2014 -0800
> # Node ID 742fb1a59b705ba71f2bab5fede58ff5885ebc71
> # Parent 234c5ecb00c04c67bcbb4a3be45fd844f2289462
> Core: parse octal/hexadecimal numeric config directives.
>
> When working with modules which need configuration directives dealing with
> file modes, it's convenient to specify the numeric values in octal notation.
> For instance "hls_directory_create_mode 0775;" is recognizably rwxrwxr-x
> whereas "hls_directory_create_mode 509;" would be more prone to mistakes.

For this particular case, using some more special handler should
be better, see ngx_conf_set_access_slot() and proxy_store_access
for an example (http://nginx.org/r/proxy_store_access).

In either case, I don't think that support for octal numbers is a
good idea, especially for generic number slots.

--
Maxim Dounin
http://nginx.org/

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
Subject Author Views Posted

[PATCH] Core: parse octal/hexadecimal numeric config directives

Ari Aosved 644 November 07, 2014 04:20PM

Re: [PATCH] Core: parse octal/hexadecimal numeric config directives

Maxim Dounin 286 November 10, 2014 10:24AM



Sorry, you do not have permission to post/reply in this forum.

Online Users

Guests: 177
Record Number of Users: 8 on April 13, 2023
Record Number of Guests: 421 on December 02, 2018
Powered by nginx      Powered by FreeBSD      PHP Powered      Powered by MariaDB      ipv6 ready